Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 8555012: Fix CrOS supported_on entries in policy_templates.json. (Closed)

Created:
9 years, 1 month ago by Mattias Nissler (ping if slow)
Modified:
9 years, 1 month ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Visibility:
Public.

Description

Fix CrOS supported_on entries in policy_templates.json. BUG=None TEST=Compiles and passes tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110068

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/app/policy/policy_templates.json View 1 16 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mattias Nissler (ping if slow)
Joao, here is an easy one for you. I've meant to make this changes for ...
9 years, 1 month ago (2011-11-14 17:34:47 UTC) #1
Joao da Silva
http://codereview.chromium.org/8555012/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/8555012/diff/1/chrome/app/policy/policy_templates.json#newcode251 chrome/app/policy/policy_templates.json:251: 'supported_on': ['chrome.*:12-', 'chrome_os:0.11-'], chrome_os:0.12- http://codereview.chromium.org/8555012/diff/1/chrome/app/policy/policy_templates.json#newcode1570 chrome/app/policy/policy_templates.json:1570: 'supported_on': ['chrome.*:12-', 'chrome_os:0.11-'], ...
9 years, 1 month ago (2011-11-14 17:52:14 UTC) #2
Mattias Nissler (ping if slow)
PTAL http://codereview.chromium.org/8555012/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/8555012/diff/1/chrome/app/policy/policy_templates.json#newcode251 chrome/app/policy/policy_templates.json:251: 'supported_on': ['chrome.*:12-', 'chrome_os:0.11-'], On 2011/11/14 17:52:14, Joao da ...
9 years, 1 month ago (2011-11-14 18:01:59 UTC) #3
Joao da Silva
lgtm
9 years, 1 month ago (2011-11-14 18:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/8555012/4
9 years, 1 month ago (2011-11-15 09:48:05 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 11:00:56 UTC) #6
Change committed as 110068

Powered by Google App Engine
This is Rietveld 408576698