Protector histograms for default search provider change added.

Protector histograms for default search provider change added.

BUG=None
TEST=Manual using chrome://histogram


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110973

[Ivan Korotkov, 2011-11-21 16:15:07]

PTAL

whywhat: protector/
sky: search_engines/

[whywhat, 2011-11-21 17:14:57]

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
File chrome/browser/protector/histograms.cc (right):

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
chrome/browser/protector/histograms.cc:34: TemplateURL* prepopulated =
We need to delete it.

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
File chrome/browser/protector/histograms.h (right):

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
chrome/browser/protector/histograms.h:17: extern const char
kProtectorBackupInvalidCounter[];
Could you add comments to these counters?

http://codereview.chromium.org/8575018/diff/1/chrome/browser/search_engines/t...
File chrome/browser/search_engines/template_url_prepopulate_data.h (right):

http://codereview.chromium.org/8575018/diff/1/chrome/browser/search_engines/t...
chrome/browser/search_engines/template_url_prepopulate_data.h:49: //
|search_url| or NULL if none is found.
Document that the owner owns the returned value.

[sky, 2011-11-21 17:17:05]

search_engines LGTM

[Ivan Korotkov, 2011-11-21 17:39:21]

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
File chrome/browser/protector/histograms.cc (right):

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
chrome/browser/protector/histograms.cc:34: TemplateURL* prepopulated =
On 2011/11/21 17:14:57, whywhat wrote:
> We need to delete it.

Oops.

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
File chrome/browser/protector/histograms.h (right):

http://codereview.chromium.org/8575018/diff/1/chrome/browser/protector/histog...
chrome/browser/protector/histograms.h:17: extern const char
kProtectorBackupInvalidCounter[];
On 2011/11/21 17:14:57, whywhat wrote:
> Could you add comments to these counters?

Done.

http://codereview.chromium.org/8575018/diff/1/chrome/browser/search_engines/t...
File chrome/browser/search_engines/template_url_prepopulate_data.h (right):

http://codereview.chromium.org/8575018/diff/1/chrome/browser/search_engines/t...
chrome/browser/search_engines/template_url_prepopulate_data.h:49: //
|search_url| or NULL if none is found.
On 2011/11/21 17:14:57, whywhat wrote:
> Document that the owner owns the returned value.

Done.

[commit-bot: I haz the power, 2011-11-21 17:41:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/8575018/4002

[commit-bot: I haz the power, 2011-11-21 19:19:59]

Change committed as 110973