Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_ | 5 #ifndef CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_ |
| 6 #define CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_ | 6 #define CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_ |
| 7 #pragma once | 7 #pragma once |
| 8 | 8 |
| 9 class TemplateURL; | |
| 10 | |
| 9 namespace protector { | 11 namespace protector { |
| 10 | 12 |
| 11 // Histogram name to report protection errors for the default search | 13 // Histogram name to report protection errors for the default search |
| 12 // provider. | 14 // provider. |
| 13 extern const char kProtectorHistogramDefaultSearchProvider[]; | 15 extern const char kProtectorHistogramDefaultSearchProvider[]; |
| 14 | 16 |
| 15 extern const char kProtectorBackupInvalidCounter[]; | 17 extern const char kProtectorBackupInvalidCounter[]; |
|
whywhat
2011/11/21 17:14:57
Could you add comments to these counters?
Ivan Korotkov
2011/11/21 17:39:22
Done.
| |
| 16 extern const char kProtectorValueChangedCounter[]; | 18 extern const char kProtectorValueChangedCounter[]; |
| 17 extern const char kProtectorValueValidCounter[]; | 19 extern const char kProtectorValueValidCounter[]; |
| 18 | 20 |
| 19 // Protector histogram values. | 21 // Protector histogram values. |
| 20 enum ProtectorError { | 22 enum ProtectorError { |
| 21 kProtectorErrorBackupInvalid, | 23 kProtectorErrorBackupInvalid, |
| 22 kProtectorErrorValueChanged, | 24 kProtectorErrorValueChanged, |
| 23 kProtectorErrorValueValid, | 25 kProtectorErrorValueValid, |
| 24 | 26 |
| 25 // This is for convenience only, must always be the last. | 27 // This is for convenience only, must always be the last. |
| 26 kProtectorErrorCount | 28 kProtectorErrorCount |
| 27 }; | 29 }; |
| 28 | 30 |
| 31 // Histogram name to report the new default search provider. | |
| 32 extern const char kProtectorHistogramNewSearchProvider[]; | |
| 33 // Histogram name to report when user accepts new default search provider. | |
| 34 extern const char kProtectorHistogramSearchProviderApplied[]; | |
| 35 // Histogram name to report when user keeps previous default search provider. | |
| 36 extern const char kProtectorHistogramSearchProviderDiscarded[]; | |
| 37 // Histogram name to report when user ignores search provider change. | |
| 38 extern const char kProtectorHistogramSearchProviderTimeout[]; | |
| 39 | |
| 40 // Returns index to be used in histograms for given search provider (which may | |
| 41 // be NULL, in which case a special index will be returned). | |
| 42 int GetSearchProviderHistogramID(const TemplateURL* t_url); | |
| 43 | |
| 44 // Maximum value of search provider index in histogram enums. | |
| 45 extern const int kProtectorMaxSearchProviderID; | |
| 46 | |
| 29 } // namespace protector | 47 } // namespace protector |
| 30 | 48 |
| 31 #endif // CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_ | 49 #endif // CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_ |
| 32 | |
| OLD | NEW |