Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 8573031: base::Bind fixes (Closed)

Created:
9 years, 1 month ago by groby-ooo-7-16
Modified:
9 years, 1 month ago
Reviewers:
eroman, wtc, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), Paweł Hajdan Jr., wtc, Randy Smith (Not in Mondays), darin-cc_chromium.org, rkn
Visibility:
Public.

Description

base::Bind fixes BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110402

Patch Set 1 #

Patch Set 2 : Fixed net_unittest #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M chrome/browser/net/sqlite_origin_bound_cert_store.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/net/sqlite_origin_bound_cert_store.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/net/sqlite_origin_bound_cert_store_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/base/default_origin_bound_cert_store.h View 3 chunks +3 lines, -2 lines 2 comments Download
M net/base/default_origin_bound_cert_store.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/base/default_origin_bound_cert_store_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
9 years, 1 month ago (2011-11-16 02:33:05 UTC) #1
eroman
lgtm
9 years, 1 month ago (2011-11-16 02:48:58 UTC) #2
wtc
mattm: please do a second review of this CL because this is origin-bound certificate code. ...
9 years, 1 month ago (2011-11-16 06:30:18 UTC) #3
mattm
lgtm
9 years, 1 month ago (2011-11-16 20:56:35 UTC) #4
groby-ooo-7-16
http://codereview.chromium.org/8573031/diff/2001/net/base/default_origin_bound_cert_store.h File net/base/default_origin_bound_cert_store.h (right): http://codereview.chromium.org/8573031/diff/2001/net/base/default_origin_bound_cert_store.h#newcode55 net/base/default_origin_bound_cert_store.h:55: void FlushStore(const base::Closure& completion_task); On 2011/11/16 06:30:18, wtc wrote: ...
9 years, 1 month ago (2011-11-16 22:24:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8573031/2001
9 years, 1 month ago (2011-11-16 22:25:21 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 00:48:24 UTC) #7
Change committed as 110402

Powered by Google App Engine
This is Rietveld 408576698