base::Bind fixes

net/base/default_origin_bound_cert_store.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_DEFAULT_ORIGIN_BOUND_CERT_STORE_H_
 #define NET_BASE_DEFAULT_ORIGIN_BOUND_CERT_STORE_H_
 #pragma once
 
 #include <map>
 #include <string>
 #include <vector>
 
+#include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/synchronization/lock.h"
 #include "net/base/net_export.h"
 #include "net/base/origin_bound_cert_store.h"
 
 class Task;
 
 namespace net {
 
@@ skipping 21 matching lines @@
   // backing store will be updated.
   explicit DefaultOriginBoundCertStore(PersistentStore* store);
 
   virtual ~DefaultOriginBoundCertStore();
 
   // Flush the backing store (if any) to disk and post the given task when done.
   // WARNING: THE CALLBACK WILL RUN ON A RANDOM THREAD. IT MUST BE THREAD SAFE.
   // It may be posted to the current thread, or it may run on the thread that
   // actually does the flushing. Your Task should generally post a notification
   // to the thread you actually want to be notified on.
-  void FlushStore(Task* completion_task);
+  void FlushStore(const base::Closure& completion_task);

[wtc, 2011/11/16 06:30:18]

Should we rename the function parameter because it is no longer
a Task?

[groby-ooo-7-16, 2011/11/16 22:24:58]

We still call it a task pretty much everywhere else. (i.e. PostTask etc.)

 
   // OriginBoundCertStore implementation.
   virtual bool GetOriginBoundCert(const std::string& origin,
                           std::string* private_key_result,
                           std::string* cert_result) OVERRIDE;
   virtual void SetOriginBoundCert(const std::string& origin,
                           const std::string& private_key,
                           const std::string& cert) OVERRIDE;
   virtual void DeleteOriginBoundCert(const std::string& origin) OVERRIDE;
   virtual void DeleteAll() OVERRIDE;
@@ skipping 82 matching lines @@
 
   virtual void AddOriginBoundCert(const OriginBoundCert& cert) = 0;
 
   virtual void DeleteOriginBoundCert(const OriginBoundCert& cert) = 0;
 
   // Sets the value of the user preference whether the persistent storage
   // must be deleted upon destruction.
   virtual void SetClearLocalStateOnExit(bool clear_local_state) = 0;
 
   // Flush the store and post the given Task when complete.
-  virtual void Flush(Task* completion_task) = 0;
+  virtual void Flush(const base::Closure& completion_task) = 0;
 
  protected:
   PersistentStore();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PersistentStore);
 };
 
 }  // namespace net
 
 #endif  // NET_DEFAULT_ORIGIN_BOUND_CERT_STORE_H_