chrome/renderer/safe_browsing/phishing_classifier_delegate.cc - Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't call Run() on null callbacks. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

index e2f74ea30912cfd739fc783e3243ef763d6141bd..3e5415017b190672080ebf4ba2386d6213228782 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

@@ -6,6 +6,7 @@

#include <set>

+#include "base/bind.h"

#include "base/callback.h"

#include "base/lazy_instance.h"

#include "base/logging.h"

@@ -285,7 +286,8 @@ void PhishingClassifierDelegate::MaybeStartClassification() {

is_classifying_ = true;

classifier_->BeginClassification(

&classifier_page_text_,

- NewCallback(this, &PhishingClassifierDelegate::ClassificationDone));

+ base::Bind(&PhishingClassifierDelegate::ClassificationDone,

+ base::Unretained(this)));

}

} // namespace safe_browsing