chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc - Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't call Run() on null callbacks. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

index af255305ac3bd3633e2997cff15d3da00ed7d6e5..27926dbc6b49bf426b9a74844e24016fb920df4c 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

@@ -11,6 +11,7 @@

#include <string>

+#include "base/bind.h"

#include "base/memory/scoped_ptr.h"

#include "base/string16.h"

#include "base/utf_string_conversions.h"

@@ -99,7 +100,8 @@ class PhishingClassifierTest : public RenderViewFakeResourcesTest {

classifier_->BeginClassification(

page_text,

- NewCallback(this, &PhishingClassifierTest::ClassificationFinished));

+ base::Bind(&PhishingClassifierTest::ClassificationFinished,

+ base::Unretained(this)));

message_loop_.Run();

*phishy_score = verdict_.client_score();