Issue 8572048: Histogram appcache task queue and run times.

Issue 8572048: Histogram appcache task queue and run times. (Closed)

Created:
9 years, 1 month ago by michaeln

Modified:
9 years, 1 month ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, michaeln, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Histogram appcache task queue and run times. BUG=101972 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111001

Patch Set 5 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -6 lines)			Patch
M	webkit/appcache/appcache_histograms.h	View	1 2 3	2 chunks	+9 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_histograms.cc	View	1 2 3 4	1 chunk	+24 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_storage_impl.cc	View	1 2 3	5 chunks	+21 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

lgtm http://codereview.chromium.org/8572048/diff/6001/webkit/appcache/appcache_histograms.cc File webkit/appcache/appcache_histograms.cc (left): http://codereview.chromium.org/8572048/diff/6001/webkit/appcache/appcache_histograms.cc#oldcode18 webkit/appcache/appcache_histograms.cc:18: // static nit: I'd prefer to keep the ...

9 years, 1 month ago (2011-11-17 03:42:05 UTC) #1

michaeln

9 years, 1 month ago (2011-11-17 03:59:47 UTC) #2

I also added a new stat for how long it takes the 'completion' task to execute.

 void AddTaskCompletionRunTimeSample(delta);

http://codereview.chromium.org/8572048/diff/6001/webkit/appcache/appcache_his...
File webkit/appcache/appcache_histograms.cc (left):

http://codereview.chromium.org/8572048/diff/6001/webkit/appcache/appcache_his...
webkit/appcache/appcache_histograms.cc:18: // static
On 2011/11/17 03:42:05, rvargas wrote:
> nit: I'd prefer to keep the comment. I don't know if we have this written down
> somewhere, but that's the pattern that I've always seen.

Done.

http://codereview.chromium.org/8572048/diff/6001/webkit/appcache/appcache_sto...
File webkit/appcache/appcache_storage_impl.cc (right):

http://codereview.chromium.org/8572048/diff/6001/webkit/appcache/appcache_sto...
webkit/appcache/appcache_storage_impl.cc:175: void CallRun(base::Time
schedule_time);
On 2011/11/17 03:42:05, rvargas wrote:
> This should be TimeTicks instead.

Done.

Expand Messages | Collapse Messages