Histogram appcache task queue and run times.

webkit/appcache/appcache_storage_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/appcache/appcache_storage_impl.h"
 
 #include <algorithm>
 #include <functional>
 #include <set>
 #include <vector>
@@ skipping 154 matching lines @@
   // safe. If overriden, this base class method must be called from
   // within the override.
   virtual void CancelCompletion();
 
  protected:
   AppCacheStorageImpl* storage_;
   AppCacheDatabase* database_;
   DelegateReferenceVector delegates_;
 
  private:
-  void CallRun();
-  void CallRunCompleted();
+  void CallRun(base::Time schedule_time);

[rvargas (doing something else), 2011/11/17 03:42:05]

This should be TimeTicks instead.

[michaeln, 2011/11/17 03:59:47]

Done.

+  void CallRunCompleted(base::Time schedule_time);
   void CallDisableStorage();
 
   scoped_refptr<base::MessageLoopProxy> io_thread_;
 };
 
 void AppCacheStorageImpl::DatabaseTask::Schedule() {
   DCHECK(storage_);
   DCHECK(io_thread_->BelongsToCurrentThread());
   if (storage_->db_thread_->PostTask(
       FROM_HERE,
-      base::Bind(&DatabaseTask::CallRun, this))) {
+      base::Bind(&DatabaseTask::CallRun, this, base::Time::Now()))) {
     storage_->scheduled_database_tasks_.push_back(this);
   } else {
     NOTREACHED() << "The database thread is not running.";
   }
 }
 
 void AppCacheStorageImpl::DatabaseTask::CancelCompletion() {
   DCHECK(io_thread_->BelongsToCurrentThread());
   delegates_.clear();
   storage_ = NULL;
 }
 
-void AppCacheStorageImpl::DatabaseTask::CallRun() {
+void AppCacheStorageImpl::DatabaseTask::CallRun(base::Time schedule_time) {
+  AppCacheHistograms::AddTaskQueueTimeSample(
+      base::Time::Now() - schedule_time);
   if (!database_->is_disabled()) {
+    base::Time run_time = base::Time::Now();
     Run();
+    AppCacheHistograms::AddTaskRunTimeSample(base::Time::Now() - run_time);
     if (database_->is_disabled()) {
       io_thread_->PostTask(
           FROM_HERE,
           base::Bind(&DatabaseTask::CallDisableStorage, this));
     }
   }
   io_thread_->PostTask(
       FROM_HERE,
-      base::Bind(&DatabaseTask::CallRunCompleted, this));
+      base::Bind(&DatabaseTask::CallRunCompleted, this, base::Time::Now()));
 }
 
-void AppCacheStorageImpl::DatabaseTask::CallRunCompleted() {
+void AppCacheStorageImpl::DatabaseTask::CallRunCompleted(
+    base::Time schedule_time) {
+  AppCacheHistograms::AddTaskCompletionTimeSample(
+      base::Time::Now() - schedule_time);
   if (storage_) {
     DCHECK(io_thread_->BelongsToCurrentThread());
     DCHECK(storage_->scheduled_database_tasks_.front() == this);
     storage_->scheduled_database_tasks_.pop_front();
     RunCompleted();
     delegates_.clear();
   }
 }
 
 void AppCacheStorageImpl::DatabaseTask::CallDisableStorage() {
@@ skipping 617 matching lines @@
     AppCacheDatabase::GroupRecord preferred_group;
     AppCacheDatabase::CacheRecord preferred_cache;
     if (database_->FindGroupForManifestUrl(
             preferred_manifest_url_, &preferred_group) &&
         database_->FindCacheForGroup(
             preferred_group.group_id, &preferred_cache)) {
       preferred_cache_id = preferred_cache.cache_id;
     }
   }
 
+  // TODO(michaeln): Also lookup matches in intercept namespaces.
+  // http://code.google.com/p/chromium/issues/detail?id=101565
   if (FindExactMatch(preferred_cache_id) ||
       FindFallback(preferred_cache_id)) {
     // We found something.
     DCHECK(cache_id_ != kNoCacheId && !manifest_url_.is_empty() &&
            group_id_ != 0);
     return;
   }
 
   // We didn't find anything.
   DCHECK(cache_id_ == kNoCacheId && manifest_url_.is_empty() &&
@@ skipping 794 matching lines @@
     Disable();
     if (!is_incognito_) {
       VLOG(1) << "Deleting existing appcache data and starting over.";
       db_thread_->PostTask(
           FROM_HERE, base::Bind(&DeleteDirectory, cache_directory_));
     }
   }
 }
 
 }  // namespace appcache