Make ClientSocketPoolManager into an interface.

Make ClientSocketPoolManager into an interface.

This allows for using a MockClientSocketPoolManager. The default implementation has been moved into ClientSocketPoolManagerImpl. This allows HttpNetworkSessionPeer to replace the whole ClientSocketPoolManager rather than individual socket pools, which is necessary because socket pools will become more integrated in the future.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110510

[willchan no longer on Chromium, 2011-11-16 01:05:07]

Shared build is giving me trouble, but I'll fix it tomorrow.

[willchan no longer on Chromium, 2011-11-16 15:59:09]

Great, I've got the shared builds to work now.

[mmenke, 2011-11-16 16:12:03]

LGTM

http://codereview.chromium.org/8572041/diff/8001/net/http/http_network_session.h
File net/http/http_network_session.h (right):

http://codereview.chromium.org/8572041/diff/8001/net/http/http_network_sessio...
net/http/http_network_session.h:95: TransportClientSocketPool*
transport_socket_pool() {
nit:  These functions should be renamed.

http://codereview.chromium.org/8572041/diff/8001/net/socket/client_socket_poo...
File net/socket/client_socket_pool_manager_impl.cc (right):

http://codereview.chromium.org/8572041/diff/8001/net/socket/client_socket_poo...
net/socket/client_socket_pool_manager_impl.cc:144:
ClientSocketPoolManagerImpl::GetTransportSocketPool() {
nit:  This method and the next should be below the body of CloseIdleSockets,
with the other somewhat similar functions, matching the header file.

http://codereview.chromium.org/8572041/diff/8001/net/socket/mock_client_socke...
File net/socket/mock_client_socket_pool_manager.cc (right):

http://codereview.chromium.org/8572041/diff/8001/net/socket/mock_client_socke...
net/socket/mock_client_socket_pool_manager.cc:45: void
MockClientSocketPoolManager::FlushSocketPools() {}
NOTREACHED() or NOTIMPLEMENTED(), maybe?  The same for CloseIdleSockets, if you
can get away with it.

Might as well also add it for SocketPoolInfoToValue, though that one doesn't
really matter.

[willchan no longer on Chromium, 2011-11-16 17:26:06]

http://codereview.chromium.org/8572041/diff/8001/net/http/http_network_session.h
File net/http/http_network_session.h (right):

http://codereview.chromium.org/8572041/diff/8001/net/http/http_network_sessio...
net/http/http_network_session.h:95: TransportClientSocketPool*
transport_socket_pool() {
On 2011/11/16 16:12:03, Matt Menke wrote:
> nit:  These functions should be renamed.

Done.

http://codereview.chromium.org/8572041/diff/8001/net/socket/client_socket_poo...
File net/socket/client_socket_pool_manager_impl.cc (right):

http://codereview.chromium.org/8572041/diff/8001/net/socket/client_socket_poo...
net/socket/client_socket_pool_manager_impl.cc:144:
ClientSocketPoolManagerImpl::GetTransportSocketPool() {
On 2011/11/16 16:12:03, Matt Menke wrote:
> nit:  This method and the next should be below the body of CloseIdleSockets,
> with the other somewhat similar functions, matching the header file.

Done.

http://codereview.chromium.org/8572041/diff/8001/net/socket/mock_client_socke...
File net/socket/mock_client_socket_pool_manager.cc (right):

http://codereview.chromium.org/8572041/diff/8001/net/socket/mock_client_socke...
net/socket/mock_client_socket_pool_manager.cc:45: void
MockClientSocketPoolManager::FlushSocketPools() {}
On 2011/11/16 16:12:03, Matt Menke wrote:
> NOTREACHED() or NOTIMPLEMENTED(), maybe?  The same for CloseIdleSockets, if
you
> can get away with it.
> 
> Might as well also add it for SocketPoolInfoToValue, though that one doesn't
> really matter.

Done.

[commit-bot: I haz the power, 2011-11-16 17:28:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/willchan@chromium.org/8572041/14001

[commit-bot: I haz the power, 2011-11-16 18:04:38]

Try job failure for 8572041-14001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-16 19:14:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/willchan@chromium.org/8572041/18001

[commit-bot: I haz the power, 2011-11-16 20:53:25]

Try job failure for 8572041-18001 (retry) on win_rel for step "ui_tests".
It's a second try, previously, steps "net_unittests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-17 15:45:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/willchan@chromium.org/8572041/18001

[commit-bot: I haz the power, 2011-11-17 16:42:05]

Change committed as 110510