Make ClientSocketPoolManager into an interface.

net/http/http_network_session.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_NETWORK_SESSION_H_
 #define NET_HTTP_HTTP_NETWORK_SESSION_H_
 #pragma once
 
 #include <set>
 #include "base/memory/ref_counted.h"
@@ skipping 19 matching lines @@
 class DnsCertProvenanceChecker;
 class DnsRRResolver;
 class HostResolver;
 class HttpAuthHandlerFactory;
 class HttpNetworkSessionPeer;
 class HttpProxyClientSocketPool;
 class HttpResponseBodyDrainer;
 class HttpServerProperties;
 class NetLog;
 class NetworkDelegate;
+class OriginBoundCertService;
 class ProxyService;
+class SOCKSClientSocketPool;
+class SSLClientSocketPool;
 class SSLConfigService;
 class SSLHostInfoFactory;
+class TransportClientSocketPool;
 
 // This class holds session objects used by HttpNetworkTransaction objects.
 class NET_EXPORT HttpNetworkSession
     : public base::RefCounted<HttpNetworkSession>,
       NON_EXPORTED_BASE(public base::NonThreadSafe) {
  public:
   struct NET_EXPORT Params {
     Params()
         : client_socket_factory(NULL),
           host_resolver(NULL),
@@ skipping 28 matching lines @@
 
   HttpAuthCache* http_auth_cache() { return &http_auth_cache_; }
   SSLClientAuthCache* ssl_client_auth_cache() {
     return &ssl_client_auth_cache_;
   }
 
   void AddResponseDrainer(HttpResponseBodyDrainer* drainer);
 
   void RemoveResponseDrainer(HttpResponseBodyDrainer* drainer);
 
   TransportClientSocketPool* transport_socket_pool() {

[mmenke, 2011/11/16 16:12:03]

nit:  These functions should be renamed.

[willchan no longer on Chromium, 2011/11/16 17:26:06]

Done.

-    return socket_pool_manager_.transport_socket_pool();
+    return socket_pool_manager_->GetTransportSocketPool();
   }
 
   SSLClientSocketPool* ssl_socket_pool() {
-    return socket_pool_manager_.ssl_socket_pool();
+    return socket_pool_manager_->GetSSLSocketPool();
   }
 
   SOCKSClientSocketPool* GetSocketPoolForSOCKSProxy(
       const HostPortPair& socks_proxy);
 
   HttpProxyClientSocketPool* GetSocketPoolForHTTPProxy(
       const HostPortPair& http_proxy);
 
   SSLClientSocketPool* GetSocketPoolForSSLWithProxy(
       const HostPortPair& proxy_server);
@@ skipping 40 matching lines @@
   HttpServerProperties* const http_server_properties_;
   CertVerifier* const cert_verifier_;
   HttpAuthHandlerFactory* const http_auth_handler_factory_;
 
   // Not const since it's modified by HttpNetworkSessionPeer for testing.
   ProxyService* proxy_service_;
   const scoped_refptr<SSLConfigService> ssl_config_service_;
 
   HttpAuthCache http_auth_cache_;
   SSLClientAuthCache ssl_client_auth_cache_;
-  ClientSocketPoolManager socket_pool_manager_;
+  scoped_ptr<ClientSocketPoolManager> socket_pool_manager_;
   SpdySessionPool spdy_session_pool_;
   scoped_ptr<HttpStreamFactory> http_stream_factory_;
   std::set<HttpResponseBodyDrainer*> response_drainers_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_NETWORK_SESSION_H_