Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 8572009: WebSocket Pepper API documents minor revision (Closed)

Created:
9 years, 1 month ago by Takashi Toyoshima
Modified:
9 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

WebSocket Pepper API documents minor revision BUG=87310 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110260

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed reviewed point #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M ppapi/api/dev/ppb_websocket_dev.idl View 1 7 chunks +19 lines, -15 lines 0 comments Download
M ppapi/c/dev/ppb_websocket_dev.h View 1 8 chunks +20 lines, -16 lines 0 comments Download
M ppapi/cpp/dev/websocket_dev.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Takashi Toyoshima
I'd like to make minor revision on WebSocket Pepper API documents. Could you review on ...
9 years, 1 month ago (2011-11-15 14:45:13 UTC) #1
dmichael (off chromium)
one suggestion, otherwise LGTM http://codereview.chromium.org/8572009/diff/1/ppapi/api/dev/ppb_websocket_dev.idl File ppapi/api/dev/ppb_websocket_dev.idl (right): http://codereview.chromium.org/8572009/diff/1/ppapi/api/dev/ppb_websocket_dev.idl#newcode290 ppapi/api/dev/ppb_websocket_dev.idl:290: * before connect() is called, ...
9 years, 1 month ago (2011-11-15 17:33:11 UTC) #2
Takashi Toyoshima
Thanks. I fixed it.
9 years, 1 month ago (2011-11-15 17:50:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8572009/1004
9 years, 1 month ago (2011-11-16 02:31:20 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 05:25:02 UTC) #5
Change committed as 110260

Powered by Google App Engine
This is Rietveld 408576698