Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: ppapi/api/dev/ppb_websocket_dev.idl

Issue 8572009: WebSocket Pepper API documents minor revision (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed reviewed point Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/c/dev/ppb_websocket_dev.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/api/dev/ppb_websocket_dev.idl
diff --git a/ppapi/api/dev/ppb_websocket_dev.idl b/ppapi/api/dev/ppb_websocket_dev.idl
index c4819108e736101932a7a1d96fcee30a84333aab..6dd0bd86c08de14cdefa5cdfb46252473980fdd4 100644
--- a/ppapi/api/dev/ppb_websocket_dev.idl
+++ b/ppapi/api/dev/ppb_websocket_dev.idl
@@ -19,6 +19,10 @@ label Chrome {
[assert_size(4)]
enum PP_WebSocketReadyState_Dev {
/**
+ * Ready state is queried on an invalid resource.
+ */
+ PP_WEBSOCKETREADYSTATE_INVALID_DEV = -1,
+ /**
* Ready state that the connection has not yet been established.
*/
PP_WEBSOCKETREADYSTATE_CONNECTING_DEV = 0,
@@ -232,9 +236,9 @@ interface PPB_WebSocket_Dev {
* @param[in] web_socket A <code>PP_Resource</code> corresponding to a
* WebSocket.
*
- * @return Returns a <code>PP_VARTYPE_NULL</code> var if called before the
- * close reason is set, or <code>PP_VARTYPE_UNDEFINED</code> if called on an
- * invalid resource.
+ * @return Returns a <code>PP_VARTYPE_STRING</code> var. if called before the
+ * close reason is set, its data is empty string. Returns a
+ * <code>PP_VARTYPE_UNDEFINED</code> if called on an invalid resource.
*/
PP_Var GetCloseReason([in] PP_Resource web_socket);
@@ -246,9 +250,9 @@ interface PPB_WebSocket_Dev {
* WebSocket.
*
* @return Returns <code>PP_FALSE</code> if called before the connection is
- * closed. Otherwise, returns <code>PP_TRUE</code> if the connection was
- * closed cleanly and returns <code>PP_FALSE</code> if the connection was
- * closed by abnormal reasons.
+ * closed, or called on an invalid resource. Otherwise, returns
+ * <code>PP_TRUE</code> if the connection was closed cleanly, or returns
+ * <code>PP_FALSE</code> if the connection was closed by abnormal reasons.
*/
PP_Bool GetCloseWasClean([in] PP_Resource web_socket);
@@ -260,9 +264,9 @@ interface PPB_WebSocket_Dev {
* WebSocket.
*
* @return Returns a <code>PP_VARTYPE_STRING</code> var. If called before the
- * connection is established or called on an invalid resource, its data is
- * empty string.
- * Currently its data is always empty string.
+ * connection is established, its data is empty string. Returns a
+ * <code>PP_VARTYPE_UNDEFINED</code> if called on an invalid resource.
+ * Currently its data for valid resources are always empty string.
*/
PP_Var GetExtensions([in] PP_Resource web_socket);
@@ -274,8 +278,8 @@ interface PPB_WebSocket_Dev {
* WebSocket.
*
* @return Returns a <code>PP_VARTYPE_STRING</code> var. If called before the
- * connection is established, or called on an invalid resource, its data is
- * empty string.
+ * connection is established, its data is empty string. Returns a
+ * <code>PP_VARTYPE_UNDEFINED</code> if called on an invalid resource.
*/
PP_Var GetProtocol([in] PP_Resource web_socket);
@@ -286,8 +290,8 @@ interface PPB_WebSocket_Dev {
* @param[in] web_socket A <code>PP_Resource</code> corresponding to a
* WebSocket.
*
- * @return Returns <code>PP_WEBSOCKETREADYSTATE_CONNECTING</code> if called
- * before the connection is established.
+ * @return Returns <code>PP_WEBSOCKETREADYSTATE_INVALID_DEV</code> if called
+ * before connect() is called, or called on an invalid resource.
*/
PP_WebSocketReadyState_Dev GetReadyState([in] PP_Resource web_socket);
@@ -298,8 +302,8 @@ interface PPB_WebSocket_Dev {
* WebSocket.
*
* @return Returns a <code>PP_VARTYPE_STRING</code> var. If called before the
- * connection is established, or called on an invalid resource, its data is
- * empty string.
+ * connection is established, its data is empty string. Return a
+ * <code>PP_VARTYPE_UNDEFINED</code> if called on an invalid resource.
*/
PP_Var GetURL([in] PP_Resource web_socket);
};
« no previous file with comments | « no previous file | ppapi/c/dev/ppb_websocket_dev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698