Issue 8571008: Revert 110099 - Creation of cookie_utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8571008: Revert 110099 - Creation of cookie_utils. (Closed)

Created:
9 years, 1 month ago by Jói

Modified:
9 years, 1 month ago

Reviewers:
droger_google

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), Erik does not do reviews, Paweł Hajdan Jr., wtc, Randy Smith (Not in Mondays), mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, rkn

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 110099 - Creation of cookie_utils. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8465022 TBR=droger@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110105

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -136 lines)			Patch
M	chrome/browser/extensions/extension_cookies_helpers.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	net/base/cookie_monster.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/base/cookie_monster.cc	View	8 chunks	+76 lines, -11 lines	0 comments	Download
M	net/base/cookie_monster_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
D	net/base/cookie_utils.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	net/base/cookie_utils.cc	View	1 chunk	+0 lines, -79 lines	0 comments	Download
M	net/net.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jói

Not sure why the error occurred, but it is definitely from this change. Cheers, Jói

9 years, 1 month ago (2011-11-15 16:48:41 UTC) #2

Jói

9 years, 1 month ago (2011-11-15 17:35:35 UTC) #5

Hi David,

It's here: 
http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28s...

I didn't have time to look very hard, there were many things going on
at the time, but I didn't understand exactly why the compile failed.

Cheers,
Jói

On Tue, Nov 15, 2011 at 5:27 PM,  <droger@google.com> wrote:
> Actually I don't understand what was the error.
>
> http://codereview.chromium.org/8571008/
>

Expand Messages | Collapse Messages