Creation of cookie_utils.

Creation of cookie_utils.

BUG=NONE
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110099

[droger_google, 2011-11-10 14:42:18]

I did not run the try bots (I don't have commit access).

[erikwright (departed), 2011-11-10 15:02:27]

http://codereview.chromium.org/8465022/diff/1/net/base/cookie_utils.cc
File net/base/cookie_utils.cc (right):

http://codereview.chromium.org/8465022/diff/1/net/base/cookie_utils.cc#newcode69
net/base/cookie_utils.cc:69: cookie_domain.length(), cookie_domain))
Nit: I know you are just moving this code, but can you fix the lack of braces
around this 'return false' while you are here? (multi-line 'if' clause).

[commit-bot: I haz the power, 2011-11-10 18:41:40]

No LGTM from valid reviewers yet.

[erikwright (departed), 2011-11-10 18:55:14]

LGTM.

Randy, sorry to bug you again for a rubber stamp. I'll prioritize doing the
directory moving next week so that I can have a dedicated OWNERS file.

[wtc, 2011-11-10 19:29:29]

Review comments on Patch Set 3:

http://codereview.chromium.org/8465022/diff/7001/net/base/cookie_utils.h
File net/base/cookie_utils.h (right):

http://codereview.chromium.org/8465022/diff/7001/net/base/cookie_utils.h#newc...
net/base/cookie_utils.h:5: #ifndef NET_BASE_COOKIE_UTILS_H_

Please name these two files cookie_util.h and cookie_util.cc,
without the 's'.  This is the convention in src/base and
src/net.

http://codereview.chromium.org/8465022/diff/7001/net/base/cookie_utils.h#newc...
net/base/cookie_utils.h:14: namespace cookie_utils {

Same with the namespace name: please remove the 's'.

http://codereview.chromium.org/8465022/diff/7001/net/base/cookie_utils.h#newc...
net/base/cookie_utils.h:33: bool DomainIsHostOnly(const std::string&
domain_string);

Based on what I see in this CL, only DomainIsHostOnly is
worth moving out of CookieMonster.  GetEffectiveDomain and
GetCookieDomainWithString are still only used in cookie_monster.cc,
so it seems that they can remain in that .cc file.

[Randy Smith (Not in Mondays), 2011-11-11 20:47:29]

Agreed with Wan-Teh's comments, LGTM if those are resolved.

[commit-bot: I haz the power, 2011-11-15 15:00:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@google.com/8465022/7001

[commit-bot: I haz the power, 2011-11-15 16:34:59]

Change committed as 110099