Issue 8570006: Allow updates to user-level products when system-level products are present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8570006: Allow updates to user-level products when system-level products are present. (Closed)

Created:
9 years, 1 month ago by grt (UTC plus 2)

Modified:
9 years, 1 month ago

Reviewers:
robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow updates to user-level products when system-level products are present. This will drop the frequency of update error 6 (SYSTEM_LEVEL_INSTALL_EXISTS). There's no good reason to block updates in this case, only new installs. BUG=103374 TEST=Install user-level Chrome, Install system-level Chrome, Update the user-level Chrome. Expect the update to succeed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110165

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed robert's nit #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -32 lines)			Patch
M	chrome/app/chromium_strings.grd	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/setup/setup_main.cc	View	1	1 chunk	+31 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertshield

LGTM with nit: http://codereview.chromium.org/8570006/diff/1/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): http://codereview.chromium.org/8570006/diff/1/chrome/installer/setup/setup_main.cc#newcode523 chrome/installer/setup/setup_main.cc:523: // Display an error message for ...

9 years, 1 month ago (2011-11-15 18:58:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/8570006/5

9 years, 1 month ago (2011-11-15 20:00:06 UTC) #3

Change committed as 110165

Expand Messages | Collapse Messages