Allow updates to user-level products when system-level products are present.

chrome/installer/setup/setup_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <msi.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include <string>
@@ skipping 475 matching lines @@
             IDS_INSTALL_MULTI_INSTALLATION_EXISTS_BASE, NULL);
         return false;
       }
     }
 
     // Check to avoid attempting to lay down a user-level installation on top
     // of a system-level one.
     const ProductState* other_state =
         original_state.GetProductState(!system_level, browser_dist->GetType());
     if (other_state != NULL && !system_level) {
-      LOG(ERROR) << "Already installed version "
-                 << other_state->version().GetString()
-                 << " conflicts with the current install mode.";
-      if (is_first_install && product->is_chrome()) {
-        // This is user-level install and there is a system-level chrome
-        // installation. Instruct Google Update to launch the existing one.
-        // There should be no error dialog.
-        FilePath chrome_exe(installer::GetChromeInstallPath(!system_level,
-                                                            browser_dist));
-        if (chrome_exe.empty()) {
-          // If we failed to construct install path. Give up.
-          *status = installer::OS_ERROR;
-          installer_state->WriteInstallerResult(*status,
-              IDS_INSTALL_OS_ERROR_BASE, NULL);
-        } else {
-          *status = installer::EXISTING_VERSION_LAUNCHED;
-          chrome_exe = chrome_exe.Append(installer::kChromeExe);
-          CommandLine cmd(chrome_exe);
-          cmd.AppendSwitch(switches::kFirstRun);
-          installer_state->WriteInstallerResult(*status, 0, NULL);
-          VLOG(1) << "Launching existing system-level chrome instead.";
-          base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
+      if (is_first_install) {
+        // This is a user-level install and there is a system-level install of
+        // the product.
+        LOG(ERROR) << "Already installed version "
+                   << other_state->version().GetString()
+                   << " at system-level conflicts with this one at user-level.";
+        if (product->is_chrome()) {
+          // Instruct Google Update to launch the existing system-level Chrome.
+          // There should be no error dialog.
+          FilePath chrome_exe(installer::GetChromeInstallPath(!system_level,
+                                                              browser_dist));
+          if (chrome_exe.empty()) {
+            // If we failed to construct install path. Give up.
+            *status = installer::OS_ERROR;
+            installer_state->WriteInstallerResult(*status,
+                IDS_INSTALL_OS_ERROR_BASE, NULL);
+          } else {
+            *status = installer::EXISTING_VERSION_LAUNCHED;
+            chrome_exe = chrome_exe.Append(installer::kChromeExe);
+            CommandLine cmd(chrome_exe);
+            cmd.AppendSwitch(switches::kFirstRun);
+            installer_state->WriteInstallerResult(*status, 0, NULL);
+            VLOG(1) << "Launching existing system-level chrome instead.";
+            base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
+          }
+          return false;
         }
+        // Display an error message for Chrome Frame.

[robertshield, 2011/11/15 18:58:27]

Wrap lines 523 - 526 in an else block and deleting the return statement on line
521.

+        *status = installer::SYSTEM_LEVEL_INSTALL_EXISTS;
+        installer_state->WriteInstallerResult(*status,
+            IDS_INSTALL_SYSTEM_LEVEL_EXISTS_BASE, NULL);
         return false;
       }
-
-      // This is an update, not an install. Omaha should know the difference
-      // and not show a dialog.
-      *status = installer::SYSTEM_LEVEL_INSTALL_EXISTS;
-      installer_state->WriteInstallerResult(*status,
-          IDS_INSTALL_SYSTEM_LEVEL_EXISTS_BASE, NULL);
-      return false;
+      // This is an update, not a new install. Allow it to take place so that
+      // out-of-date versions are not left around.
     }
   }
 
   // If no previous installation of Chrome, make sure installation directory
   // either does not exist or can be deleted (i.e. is not locked by some other
   // process).
   if (is_first_install) {
     if (file_util::PathExists(installer_state->target_path()) &&
         !file_util::Delete(installer_state->target_path(), true)) {
       LOG(ERROR) << "Installation directory "
@@ skipping 799 matching lines @@
   if (!(installer_state.is_msi() && is_uninstall))
     // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT
     // to pass through, since this is only returned on uninstall which is
     // never invoked directly by Google Update.
     return_code = InstallUtil::GetInstallReturnCode(install_status);
 
   VLOG(1) << "Installation complete, returning: " << return_code;
 
   return return_code;
 }