Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 8570002: Fix a cause of flakyness in NativeTextfieldViewsTest.ReadOnlyTest. (Closed)

Created:
9 years, 1 month ago by Alexei Svitkine (slow)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, penghuang+watch_chromium.org, Paweł Hajdan Jr., James Su, dhollowa
Visibility:
Public.

Description

Fix a cause of flakyness in NativeTextfieldViewsTest.ReadOnlyTest. Make the test set the clipboard first before testing that CUT doesn't set the clipboard. Without this, the test would fail when run a second time due to existing clipboard contents. Also, refactor the code to add test helper methods for getting and setting clipboard text. BUG=none TEST=Run NativeTextfieldViewsTest.ReadOnlyTest twice. The second time should not fail. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M views/controls/textfield/native_textfield_views_unittest.cc View 4 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
9 years, 1 month ago (2011-11-15 15:29:32 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-15 16:55:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8570002/1
9 years, 1 month ago (2011-11-15 17:06:07 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 18:22:44 UTC) #4
Change committed as 110118

Powered by Google App Engine
This is Rietveld 408576698