Fix a cause of flakyness in NativeTextfieldViewsTest.ReadOnlyTest.

views/controls/textfield/native_textfield_views_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 230 matching lines @@
           ch == ' ' ? ui::VKEY_SPACE :
           static_cast<ui::KeyboardCode>(ui::VKEY_A + ch - 'a');
       SendKeyEvent(code);
     } else {
       KeyEvent event(ui::ET_KEY_PRESSED, ui::VKEY_UNKNOWN, 0);
       event.set_character(ch);
       input_method_->DispatchKeyEvent(event);
     }
   }
 
+  string16 GetClipboardText() const {
+    string16 text;
+    views::ViewsDelegate::views_delegate->GetClipboard()->
+        ReadText(ui::Clipboard::BUFFER_STANDARD, &text);
+    return text;
+  }
+
+  void SetClipboardText(const std::string& text) {
+    ui::ScopedClipboardWriter clipboard_writer(
+        views::ViewsDelegate::views_delegate->GetClipboard());
+    clipboard_writer.WriteText(ASCIIToUTF16(text));
+  }
+
   View* GetFocusedView() {
     return widget_->GetFocusManager()->GetFocusedView();
   }
 
   int GetCursorPositionX(int cursor_pos) {
     gfx::RenderText* render_text = textfield_view_->GetRenderText();
     return render_text->GetCursorBounds(
         gfx::SelectionModel(cursor_pos), false).x();
   }
 
@@ skipping 34 matching lines @@
     MouseEvent release(ui::ET_MOUSE_RELEASED, 0, 0,
                        ui::EF_LEFT_BUTTON_DOWN | ui::EF_IS_NON_CLIENT);
     textfield_view_->OnMouseReleased(release);
   }
 
   // Wrap for visibility in test classes.
   ui::TextInputType GetTextInputType() {
     return textfield_view_->GetTextInputType();
   }
 
+  void VerifyTextfieldContextMenuContents(bool textfield_has_selection,
+                                          ui::MenuModel* menu_model) {
+    EXPECT_TRUE(menu_model->IsEnabledAt(4 /* Separator */));
+    EXPECT_TRUE(menu_model->IsEnabledAt(5 /* SELECT ALL */));
+    EXPECT_EQ(textfield_has_selection, menu_model->IsEnabledAt(0 /* CUT */));
+    EXPECT_EQ(textfield_has_selection, menu_model->IsEnabledAt(1 /* COPY */));
+    EXPECT_EQ(textfield_has_selection, menu_model->IsEnabledAt(3 /* DELETE */));
+    string16 str(GetClipboardText());
+    EXPECT_NE(str.empty(), menu_model->IsEnabledAt(2 /* PASTE */));
+  }
+
   // We need widget to populate wrapper class.
   Widget* widget_;
 
   TestTextfield* textfield_;
   NativeTextfieldViews* textfield_view_;
   TextfieldViewsModel* model_;
 
   // The string from Controller::ContentsChanged callback.
   string16 last_contents_;
 
@@ skipping 327 matching lines @@
   EXPECT_EQ(1, GetFocusedView()->id());
 
   // Test if clicking on textfield view sets the focus to textfield_.
   widget_->GetFocusManager()->AdvanceFocus(true);
   EXPECT_EQ(3, GetFocusedView()->id());
   MouseEvent click(ui::ET_MOUSE_PRESSED, 0, 0, ui::EF_LEFT_BUTTON_DOWN);
   textfield_view_->OnMousePressed(click);
   EXPECT_EQ(1, GetFocusedView()->id());
 }
 
-void VerifyTextfieldContextMenuContents(bool textfield_has_selection,
-    ui::MenuModel* menu_model) {
-  EXPECT_TRUE(menu_model->IsEnabledAt(4 /* Separator */));
-  EXPECT_TRUE(menu_model->IsEnabledAt(5 /* SELECT ALL */));
-  EXPECT_EQ(textfield_has_selection, menu_model->IsEnabledAt(0 /* CUT */));
-  EXPECT_EQ(textfield_has_selection, menu_model->IsEnabledAt(1 /* COPY */));
-  EXPECT_EQ(textfield_has_selection, menu_model->IsEnabledAt(3 /* DELETE */));
-  string16 str;
-  views::ViewsDelegate::views_delegate->GetClipboard()->
-      ReadText(ui::Clipboard::BUFFER_STANDARD, &str);
-  EXPECT_NE(str.empty(), menu_model->IsEnabledAt(2 /* PASTE */));
-}
-
 TEST_F(NativeTextfieldViewsTest, ContextMenuDisplayTest) {
   InitTextfield(Textfield::STYLE_DEFAULT);
   textfield_->SetText(ASCIIToUTF16("hello world"));
   EXPECT_TRUE(GetContextMenuModel());
   VerifyTextfieldContextMenuContents(false, GetContextMenuModel());
 
   textfield_->SelectAll();
   VerifyTextfieldContextMenuContents(true, GetContextMenuModel());
 }
 
@@ skipping 302 matching lines @@
   EXPECT_EQ(9U, textfield_->GetCursorPosition());
 
   SendKeyEvent(ui::VKEY_LEFT, true, true);
   EXPECT_EQ(5U, textfield_->GetCursorPosition());
   EXPECT_STR_EQ("two ", textfield_->GetSelectedText());
 
   textfield_->SelectAll();
   EXPECT_STR_EQ(" one two three ", textfield_->GetSelectedText());
 
   // CUT&PASTE does not work, but COPY works
+  SetClipboardText("Test");
   SendKeyEvent(ui::VKEY_X, false, true);
   EXPECT_STR_EQ(" one two three ", textfield_->GetSelectedText());
-  string16 str;
-  views::ViewsDelegate::views_delegate->GetClipboard()->
-      ReadText(ui::Clipboard::BUFFER_STANDARD, &str);
+  string16 str(GetClipboardText());
   EXPECT_STR_NE(" one two three ", str);
 
   SendKeyEvent(ui::VKEY_C, false, true);
   views::ViewsDelegate::views_delegate->GetClipboard()->
       ReadText(ui::Clipboard::BUFFER_STANDARD, &str);
   EXPECT_STR_EQ(" one two three ", str);
 
   // SetText should work even in read only mode.
   textfield_->SetText(ASCIIToUTF16(" four five six "));
   EXPECT_STR_EQ(" four five six ", textfield_->text());
@@ skipping 543 matching lines @@
   EXPECT_EQ(0U, textfield_->GetCursorPosition());
 #else
   EXPECT_EQ(500U, textfield_->GetCursorPosition());
 #endif
 
   // Reset locale.
   base::i18n::SetICUDefaultLocale(locale);
 }
 
 }  // namespace views