Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 8567021: Port views::KeyEvent functions to aura::KeyEvent. (Closed)

Created:
9 years, 1 month ago by Yusuke Sato
Modified:
9 years, 1 month ago
Reviewers:
James Su, sky
CC:
chromium-reviews, Peng
Visibility:
Public.

Description

Port views::KeyEvent functions to aura::KeyEvent. They will be used for adding IME support to Aura. BUG=chromium:97261 TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110288

Patch Set 1 : try #

Patch Set 2 : review #

Total comments: 4

Patch Set 3 : review fix #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M ui/aura/event.h View 2 chunks +20 lines, -0 lines 0 comments Download
M ui/aura/event.cc View 1 2 3 chunks +69 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yusuke Sato
9 years, 1 month ago (2011-11-15 11:26:17 UTC) #1
James Su
LGTM http://codereview.chromium.org/8567021/diff/6001/ui/aura/event.cc File ui/aura/event.cc (right): http://codereview.chromium.org/8567021/diff/6001/ui/aura/event.cc#newcode165 ui/aura/event.cc:165: if (!native_event()) { nit: no { } for ...
9 years, 1 month ago (2011-11-15 11:51:10 UTC) #2
Yusuke Sato
http://codereview.chromium.org/8567021/diff/6001/ui/aura/event.cc File ui/aura/event.cc (right): http://codereview.chromium.org/8567021/diff/6001/ui/aura/event.cc#newcode165 ui/aura/event.cc:165: if (!native_event()) { On 2011/11/15 11:51:10, James Su wrote: ...
9 years, 1 month ago (2011-11-15 12:20:59 UTC) #3
sky
LGTM
9 years, 1 month ago (2011-11-15 16:39:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8567021/9007
9 years, 1 month ago (2011-11-16 06:47:41 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years, 1 month ago (2011-11-16 10:19:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8567021/9007
9 years, 1 month ago (2011-11-16 10:26:33 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 11:57:20 UTC) #8
Change committed as 110288

Powered by Google App Engine
This is Rietveld 408576698