Limit number of notifications that can be received by the client.

chrome/browser/extensions/app_notification_manager.h

Index: chrome/browser/extensions/app_notification_manager.h
===================================================================
--- chrome/browser/extensions/app_notification_manager.h	(revision 109957)
+++ chrome/browser/extensions/app_notification_manager.h	(working copy)
@@ -20,6 +20,9 @@
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
+namespace notification_manager_constants {

[Munjal (Google), 2011/11/17 19:45:32]

Add one empty line before namespace.

[elvin, 2011/11/17 22:28:17]

Done.

+  const unsigned int kMaxNotificationPerApp = 5;

[Munjal (Google), 2011/11/17 19:45:32]

Actually this constant is not used in header, and should go in an anonymous
namespace in the .cc file.
also, make it a static const int.

[elvin, 2011/11/17 22:28:17]

It's used in the test file?
On 2011/11/17 19:45:32, munjal wrote:

+}
 
 class Profile;
 
@@ -130,6 +133,10 @@
   // Sends a change to syncer to add the given notification.
   void SyncAddChange(const AppNotification& notif);
 
+  // Sends a change to syncer to remove the given notification.
+  void SyncRemoveChange(const AppNotification& notif,
+                        bool shouldProcessSyncerChanges);

[Munjal (Google), 2011/11/17 19:45:32]

This method is an instance method and it can access the member
processing_syncer_changes_. So you probably don't need the second parameter?

FYI, naming convention is to name it should_process_sync_changes.

[elvin, 2011/11/17 22:28:17]

REmoved
On 2011/11/17 19:45:32, munjal wrote:

+
   // Sends changes to syncer to remove all notifications in the given list.
   void SyncClearAllChange(const AppNotificationList& list);