Limit number of notifications that can be received by the client.

chrome/browser/extensions/app_notification_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_APP_NOTIFICATION_MANAGER_H_
 #define CHROME_BROWSER_EXTENSIONS_APP_NOTIFICATION_MANAGER_H_
 #pragma once
 
 #include <map>
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/synchronization/waitable_event.h"
 #include "chrome/browser/extensions/app_notification.h"
 #include "chrome/browser/extensions/app_notification_storage.h"
 #include "chrome/browser/sync/api/sync_change.h"
 #include "chrome/browser/sync/api/syncable_service.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
+namespace notification_manager_constants {

[Munjal (Google), 2011/11/17 19:45:32]

Add one empty line before namespace.

[elvin, 2011/11/17 22:28:17]

Done.

+  const unsigned int kMaxNotificationPerApp = 5;

[Munjal (Google), 2011/11/17 19:45:32]

Actually this constant is not used in header, and should go in an anonymous
namespace in the .cc file.
also, make it a static const int.

[elvin, 2011/11/17 22:28:17]

It's used in the test file?
On 2011/11/17 19:45:32, munjal wrote:

+}
 
 class Profile;
 
 // This class keeps track of notifications for installed apps.
 class AppNotificationManager
     : public base::RefCountedThreadSafe<AppNotificationManager>,
       public content::NotificationObserver,
       public SyncableService {
  public:
   explicit AppNotificationManager(Profile* profile);
@@ skipping 90 matching lines @@
   void Remove(const std::string& extension_id, const std::string& guid);
 
   // Returns the notification for the given |extension_id| and |guid|,
   // NULL if no such notification exists.
   const AppNotification* GetNotification(const std::string& extension_id,
                                          const std::string& guid);
 
   // Sends a change to syncer to add the given notification.
   void SyncAddChange(const AppNotification& notif);
 
+  // Sends a change to syncer to remove the given notification.
+  void SyncRemoveChange(const AppNotification& notif,
+                        bool shouldProcessSyncerChanges);

[Munjal (Google), 2011/11/17 19:45:32]

This method is an instance method and it can access the member
processing_syncer_changes_. So you probably don't need the second parameter?

FYI, naming convention is to name it should_process_sync_changes.

[elvin, 2011/11/17 22:28:17]

REmoved
On 2011/11/17 19:45:32, munjal wrote:

+
   // Sends changes to syncer to remove all notifications in the given list.
   void SyncClearAllChange(const AppNotificationList& list);
 
   // Converters from AppNotification to SyncData and vice versa.
   static SyncData CreateSyncDataFromNotification(
       const AppNotification& notification);
   static AppNotification* CreateNotificationFromSyncData(
       const SyncData& sync_data);
 
   Profile* profile_;
   content::NotificationRegistrar registrar_;
   scoped_ptr<NotificationMap> notifications_;
 
   // This should only be used on the FILE thread.
   scoped_ptr<AppNotificationStorage> storage_;
 
   // Sync change processor we use to push all our changes.
   SyncChangeProcessor* sync_processor_;
   // Whether the sync model is associated with the local model.
   // In other words, whether we are ready to apply sync changes.
   bool models_associated_;
   // Whether syncer changes are being processed right now.
   bool processing_syncer_changes_;
 
   DISALLOW_COPY_AND_ASSIGN(AppNotificationManager);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_APP_NOTIFICATION_MANAGER_H_