PrintPreview: [Cleanup] Remove unwanted function calls.

PrintPreview: [Cleanup] Remove unwanted function calls.

While printing for print preview, we don't want to get the source frame
css information because it is not used.

BUG=none
TEST=printing works as expected after code changes.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110815

[vandebo (ex-Chrome), 2011-11-19 00:02:20]

LGTM with nits.

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper.cc:838: prep_frame_view.reset(new
PrepareFrameAndViewForPrint(print_params, frame,
nit: no ndeed for a scoped_pointer here, a stack object will now work.

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper.cc:843: int page_count =
prepare->GetExpectedPageCount();
nit: Update var name.

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper.cc:850: const gfx::Size& canvas_size =
prepare->GetPrintCanvasSize();
nit: Update var name.

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_linux.cc (right):

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_linux.cc:66: prep_frame_view.reset(new
PrepareFrameAndViewForPrint(params.params, frame,
nit: Use a stack object.

[kmadhusu, 2011-11-19 00:20:56]

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper.cc:838: prep_frame_view.reset(new
PrepareFrameAndViewForPrint(print_params, frame,
On 2011/11/19 00:02:20, vandebo wrote:
> nit: no ndeed for a scoped_pointer here, a stack object will now work.

Done.

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper.cc:843: int page_count =
prepare->GetExpectedPageCount();
On 2011/11/19 00:02:20, vandebo wrote:
> nit: Update var name.

oops..my bad..fixed.

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper.cc:850: const gfx::Size& canvas_size =
prepare->GetPrintCanvasSize();
On 2011/11/19 00:02:20, vandebo wrote:
> nit: Update var name.

Done.

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_linux.cc (right):

http://codereview.chromium.org/8566055/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_linux.cc:66: prep_frame_view.reset(new
PrepareFrameAndViewForPrint(params.params, frame,
On 2011/11/19 00:02:20, vandebo wrote:
> nit: Use a stack object.

Done.

[commit-bot: I haz the power, 2011-11-19 00:54:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8566055/3003

[commit-bot: I haz the power, 2011-11-19 02:05:20]

Change committed as 110815