PrintPreview: [Cleanup] Remove unwanted function calls.

chrome/renderer/print_web_view_helper_linux.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #include "base/file_descriptor_posix.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
@@ skipping 39 matching lines @@
              print_preview_context_.generate_draft_pages()){
     DCHECK(!draft_metafile.get());
     draft_metafile.reset(
         print_preview_context_.metafile()->GetMetafileForCurrentPage());
   }
   return PreviewPageRendered(page_number, draft_metafile.get());
 }
 
 bool PrintWebViewHelper::PrintPages(const PrintMsg_PrintPages_Params& params,
                                     WebFrame* frame,
-                                    const WebNode& node,
-                                    PrepareFrameAndViewForPrint* prepare) {
+                                    const WebNode& node) {
   printing::NativeMetafile metafile;
   if (!metafile.Init())
     return false;
 
   scoped_ptr<PrepareFrameAndViewForPrint> prep_frame_view;
-  if (!prepare) {
-    prep_frame_view.reset(new PrepareFrameAndViewForPrint(params.params, frame,
-                                                          node));
-    prepare = prep_frame_view.get();
+  prep_frame_view.reset(new PrepareFrameAndViewForPrint(params.params, frame,

[vandebo (ex-Chrome), 2011/11/19 00:02:20]

nit: Use a stack object.

[kmadhusu, 2011/11/19 00:20:56]

Done.

+                                                        node));
+  int page_count = 0;
+  if (!RenderPages(params, frame, node, &page_count, prep_frame_view.get(),
+                   &metafile)) {
+    return false;
   }
-  int page_count = 0;
-  if (!RenderPages(params, frame, node, &page_count, prepare, &metafile))
-    return false;
 
   // Get the size of the resulting metafile.
   uint32 buf_size = metafile.GetDataSize();
   DCHECK_GT(buf_size, 0u);
 
 #if defined(OS_CHROMEOS)
   int sequence_number = -1;
   base::FileDescriptor fd;
 
   // Ask the browser to open a file for us.
@@ skipping 133 matching lines @@
     // The scale factor on Linux is 1.
     PrintHeaderAndFooter(canvas.get(), params.page_number + 1,
                          print_preview_context_.total_page_count(), 1,
                          page_layout_in_points, *header_footer_info_);
   }
 
   // Done printing. Close the device context to retrieve the compiled metafile.
   if (!metafile->FinishPage())
     NOTREACHED() << "metafile failed";
 }