Issue 8566047: Enable |ValidateAndConvertPepperFilePath()| for domain-absolute paths without ENABLE_FLAPPER_HACKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566047: Enable |ValidateAndConvertPepperFilePath()| for domain-absolute paths without ENABLE_FLAPPER_HACKS. (Closed)

Created:
9 years, 1 month ago by viettrungluu

Modified:
9 years, 1 month ago

Reviewers:
darin (slow to review), piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable |ValidateAndConvertPepperFilePath()| for domain-absolute paths without ENABLE_FLAPPER_HACKS. TBR=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110773

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	content/browser/renderer_host/pepper_file_message_filter.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

On 2011/11/18 21:13:29, piman wrote: > lgtm Thanks. TBRing darin for OWNERS review.

9 years, 1 month ago (2011-11-18 21:16:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8566047/1

9 years, 1 month ago (2011-11-18 21:17:53 UTC) #4

commit-bot: I haz the power

9 years, 1 month ago (2011-11-18 22:29:51 UTC) #5

Try job failure for 8566047-1 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages