Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: content/browser/renderer_host/pepper_file_message_filter.cc

Issue 8566047: Enable |ValidateAndConvertPepperFilePath()| for domain-absolute paths without ENABLE_FLAPPER_HACKS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/pepper_file_message_filter.cc
diff --git a/content/browser/renderer_host/pepper_file_message_filter.cc b/content/browser/renderer_host/pepper_file_message_filter.cc
index 5c84a8cd71e7217cf64829d9577179b00144379d..f8367fc8095b8531fa2dffbe29e276aa373c8ec1 100644
--- a/content/browser/renderer_host/pepper_file_message_filter.cc
+++ b/content/browser/renderer_host/pepper_file_message_filter.cc
@@ -222,16 +222,10 @@ FilePath PepperFileMessageFilter::ValidateAndConvertPepperFilePath(
FilePath file_path; // Empty path returned on error.
switch(pepper_path.domain()) {
case webkit::ppapi::PepperFilePath::DOMAIN_ABSOLUTE:
-// TODO(viettrungluu): This could be dangerous if not 100% right, so let's be
-// conservative and only enable it when requested.
-#if defined(ENABLE_FLAPPER_HACKS)
if (pepper_path.path().IsAbsolute() &&
ChildProcessSecurityPolicy::GetInstance()->HasPermissionsForFile(
child_id(), pepper_path.path(), flags))
file_path = pepper_path.path();
-#else
- NOTIMPLEMENTED();
-#endif // ENABLE_FLAPPER_HACKS
break;
case webkit::ppapi::PepperFilePath::DOMAIN_MODULE_LOCAL:
if (!pepper_path.path().IsAbsolute() &&
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698