aura: Fix unit_tests on linux

base/message_pump_observer.h

Index: base/message_pump_observer.h
diff --git a/base/message_pump_observer.h b/base/message_pump_observer.h
index efcdebfe1a2b3ecebcfbedb2379f96cec47c5ddd..006ea2a967e1f353751cbb6b5acfd430cace5d94 100644
--- a/base/message_pump_observer.h
+++ b/base/message_pump_observer.h
@@ -38,6 +38,9 @@ class BASE_EXPORT MessagePumpObserver {
   // will not be called if WillProcessEvent returns EVENT_HANDLED.
   virtual void DidProcessEvent(const NativeEvent& event) = 0;
 
+  // This method is called just before the message pump is destroyed.
+  virtual void DestroyMessagePump() {}

[oshima, 2011/11/29 21:08:11]

OnMessagePumpDestroying. how much work do we need to make this pure virtual?

[sadrul, 2011/11/29 21:21:33]

Renamed.

To make it pure virtual: I am not sure how much work that would need (probably
not much). But I tend to think that 'Observer' functions should not be pure
virtual: an observer may be interested in only some events, and not all, and
should not be forced to have implementation for every notification.

[oshima, 2011/11/30 00:04:16]

That's true if Observer interface is broad (like WindowObserver). I prefer pure
virtual for narrow interface, but I don't feel strongly about it if we add this
to MessagePumpObserver. I'll leave it to you and owners.

+
  protected:
   virtual ~MessagePumpObserver() {}
 };