aura: Fix unit_tests on linux

base/message_pump_observer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MESSAGE_PUMP_OBSERVER_H
 #define BASE_MESSAGE_PUMP_OBSERVER_H
 #pragma once
 
 #include "base/event_types.h"
 
@@ skipping 20 matching lines @@
   // method returns EVENT_HANDLED, it indicates the event has already
   // been handled, so the event is not processed any farther. If the
   // method returns EVENT_CONTINUE, the event dispatching proceeds as
   // normal.
   virtual EventStatus WillProcessEvent(const NativeEvent& event) = 0;
 
   // This method is called after processing a message. This method
   // will not be called if WillProcessEvent returns EVENT_HANDLED.
   virtual void DidProcessEvent(const NativeEvent& event) = 0;
 
+  // This method is called just before the message pump is destroyed.
+  virtual void DestroyMessagePump() {}

[oshima, 2011/11/29 21:08:11]

OnMessagePumpDestroying. how much work do we need to make this pure virtual?

[sadrul, 2011/11/29 21:21:33]

Renamed.

To make it pure virtual: I am not sure how much work that would need (probably
not much). But I tend to think that 'Observer' functions should not be pure
virtual: an observer may be interested in only some events, and not all, and
should not be forced to have implementation for every notification.

[oshima, 2011/11/30 00:04:16]

That's true if Observer interface is broad (like WindowObserver). I prefer pure
virtual for narrow interface, but I don't feel strongly about it if we add this
to MessagePumpObserver. I'll leave it to you and owners.

+
  protected:
   virtual ~MessagePumpObserver() {}
 };
 
 }  // namespace base
 
 #endif  // BASE_MESSAGE_PUMP_OBSERVER_VIEWS_H