base::Bind fixes

base::Bind fixes


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111425

[jam, 2011-11-18 19:25:35]

i'm not an expert on bind, nor familiar with this code, and you don't need my
owners approval, can you please send this to someone else?

[James Hawkins, 2011-11-19 03:31:12]

http://codereview.chromium.org/8566033/diff/1/chrome/browser/omnibox_search_h...
File chrome/browser/omnibox_search_hint.cc (right):

http://codereview.chromium.org/8566033/diff/1/chrome/browser/omnibox_search_h...
chrome/browser/omnibox_search_hint.cc:96:
MessageLoop::current()->PostDelayedTask(FROM_HERE,
nit: Start of parameter lines must start on the same column.

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
File chrome/browser/oom_priority_manager.cc (right):

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
chrome/browser/oom_priority_manager.cc:186:
&OomPriorityManager::AdjustFocusedTabScoreOnFileThread, this));
Do you still need this wrapped?

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
chrome/browser/oom_priority_manager.cc:256: stats_list));
Save a line: put this on the line above.

[groby-ooo-7-16, 2011-11-21 22:50:13]

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
File chrome/browser/oom_priority_manager.cc (right):

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
chrome/browser/oom_priority_manager.cc:186:
&OomPriorityManager::AdjustFocusedTabScoreOnFileThread, this));
What do you mean by wrapped?
On 2011/11/19 03:31:12, James Hawkins wrote:
> Do you still need this wrapped?

[groby-ooo-7-16, 2011-11-21 22:54:48]

http://codereview.chromium.org/8566033/diff/1/chrome/browser/omnibox_search_h...
File chrome/browser/omnibox_search_hint.cc (right):

http://codereview.chromium.org/8566033/diff/1/chrome/browser/omnibox_search_h...
chrome/browser/omnibox_search_hint.cc:96:
MessageLoop::current()->PostDelayedTask(FROM_HERE,
On 2011/11/19 03:31:12, James Hawkins wrote:
> nit: Start of parameter lines must start on the same column.

Done.

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
File chrome/browser/oom_priority_manager.cc (right):

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
chrome/browser/oom_priority_manager.cc:186:
&OomPriorityManager::AdjustFocusedTabScoreOnFileThread, this));
If you mean line-wrapped (sorry, only realized that after posting), yes.

It's 81 characters :(

On 2011/11/21 22:50:14, groby wrote:
> What do you mean by wrapped?
> On 2011/11/19 03:31:12, James Hawkins wrote:
> > Do you still need this wrapped?
>

http://codereview.chromium.org/8566033/diff/1/chrome/browser/oom_priority_man...
chrome/browser/oom_priority_manager.cc:256: stats_list));
On 2011/11/19 03:31:12, James Hawkins wrote:
> Save a line: put this on the line above.

Done.

[James Hawkins, 2011-11-22 00:43:37]

http://codereview.chromium.org/8566033/diff/10003/chrome/browser/omnibox_sear...
File chrome/browser/omnibox_search_hint.cc (right):

http://codereview.chromium.org/8566033/diff/10003/chrome/browser/omnibox_sear...
chrome/browser/omnibox_search_hint.cc:83: base::WeakPtrFactory<HintInfoBar>
weak_factory_;
#include "base/memory/weak_ptr.h"

http://codereview.chromium.org/8566033/diff/10003/chrome/browser/omnibox_sear...
chrome/browser/omnibox_search_hint.cc:96:
MessageLoop::current()->PostDelayedTask(FROM_HERE,
Start of parameters must all be on the same column:

---(
 FROM_HERE,
 base::Bind(...),
 8000);

[groby-ooo-7-16, 2011-11-22 03:44:44]

http://codereview.chromium.org/8566033/diff/10003/chrome/browser/omnibox_sear...
File chrome/browser/omnibox_search_hint.cc (right):

http://codereview.chromium.org/8566033/diff/10003/chrome/browser/omnibox_sear...
chrome/browser/omnibox_search_hint.cc:83: base::WeakPtrFactory<HintInfoBar>
weak_factory_;
On 2011/11/22 00:43:37, James Hawkins wrote:
> #include "base/memory/weak_ptr.h"

Done.

http://codereview.chromium.org/8566033/diff/10003/chrome/browser/omnibox_sear...
chrome/browser/omnibox_search_hint.cc:96:
MessageLoop::current()->PostDelayedTask(FROM_HERE,
On 2011/11/22 00:43:37, James Hawkins wrote:
> Start of parameters must all be on the same column:
> 
> ---(
>  FROM_HERE,
>  base::Bind(...),
>  8000);

Done.

[James Hawkins, 2011-11-22 17:12:56]

lgtm

[commit-bot: I haz the power, 2011-11-22 23:27:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/8566033/15001

[commit-bot: I haz the power, 2011-11-23 02:14:25]

Try job failure for 8566033-15001 (previous was lost) (retry) on mac_rel for
steps "browser_tests, ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-11-23 19:35:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/8566033/15001

[commit-bot: I haz the power, 2011-11-23 22:21:43]

Change committed as 111425