base::Bind fixes

chrome/browser/oom_priority_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/oom_priority_manager.h"
 
 #include <algorithm>
 #include <vector>
 
+#include "base/bind.h"
 #include "base/process.h"
 #include "base/process_util.h"
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread.h"
 #include "base/timer.h"
 #include "base/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
@@ skipping 154 matching lines @@
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   base::AutoLock pid_to_oom_score_autolock(pid_to_oom_score_lock_);
   ZygoteHost::GetInstance()->AdjustRendererOOMScore(
       focused_tab_pid_, chrome::kLowestRendererOomScore);
   pid_to_oom_score_[focused_tab_pid_] = chrome::kLowestRendererOomScore;
 }
 
 void OomPriorityManager::OnFocusTabScoreAdjustmentTimeout() {
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
-      NewRunnableMethod(
-          this, &OomPriorityManager::AdjustFocusedTabScoreOnFileThread));
+      base::Bind(
+          &OomPriorityManager::AdjustFocusedTabScoreOnFileThread, this));

[James Hawkins, 2011/11/19 03:31:12]

Do you still need this wrapped?

[groby-ooo-7-16, 2011/11/21 22:50:14]

What do you mean by wrapped?
On 2011/11/19 03:31:12, James Hawkins wrote:

[groby-ooo-7-16, 2011/11/21 22:54:48]

If you mean line-wrapped (sorry, only realized that after posting), yes.

It's 81 characters :(

On 2011/11/21 22:50:14, groby wrote:

 }
 
 void OomPriorityManager::Observe(int type,
                                  const content::NotificationSource& source,
                                  const content::NotificationDetails& details) {
   base::ProcessHandle handle = 0;
   base::AutoLock pid_to_oom_score_autolock(pid_to_oom_score_lock_);
   switch (type) {
     case content::NOTIFICATION_RENDERER_PROCESS_CLOSED: {
       handle =
@@ skipping 47 matching lines @@
 // TabStripModel isn't thread safe):
 // 1) whether or not a tab is pinned
 // 2) last time a tab was selected
 // 3) is the tab currently selected
 void OomPriorityManager::AdjustOomPriorities() {
   if (BrowserList::size() == 0)
     return;
   TabStatsList stats_list = GetTabStatsOnUIThread();
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
-      NewRunnableMethod(this,
-                        &OomPriorityManager::AdjustOomPrioritiesOnFileThread,
-                        stats_list));
+      base::Bind(&OomPriorityManager::AdjustOomPrioritiesOnFileThread,
+                 this,
+                 stats_list));

[James Hawkins, 2011/11/19 03:31:12]

Save a line: put this on the line above.

[groby-ooo-7-16, 2011/11/21 22:54:48]

Done.

 }
 
 OomPriorityManager::TabStatsList OomPriorityManager::GetTabStatsOnUIThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   TabStatsList stats_list;
   stats_list.reserve(32);  // 99% of users have < 30 tabs open
   for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
        browser_iterator != BrowserList::end(); ++browser_iterator) {
     Browser* browser = *browser_iterator;
     const TabStripModel* model = browser->tabstrip_model();
@@ skipping 57 matching lines @@
         ZygoteHost::GetInstance()->AdjustRendererOOMScore(
             iterator->renderer_handle, score);
         pid_to_oom_score_[iterator->renderer_handle] = score;
       }
       priority += priority_increment;
     }
   }
 }
 
 }  // namespace browser