Issue 8566027: Cleanup: Remove forward declarations in ui, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566027: Cleanup: Remove forward declarations in ui, part 2. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove forward declarations in ui, part 2. BUG=none TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110420

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -32 lines)			Patch
M	ui/aura/test/test_windows.h	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	ui/aura/window.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	ui/aura_shell/workspace_controller.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	ui/gfx/compositor/layer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/compositor/test_layer_animation_delegate.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/gfx/compositor/test_suite.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/gfx/linux_util.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/gfx/native_widget_types.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/wayland/wayland_input_device.h	View	3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8566027/1

9 years, 1 month ago (2011-11-16 21:22:53 UTC) #3

commit-bot: I haz the power

9 years, 1 month ago (2011-11-16 23:52:23 UTC) #5

Try job failure for 8566027-1 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages