Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: skia/ext/SkFontHost_sandbox_win.h

Issue 8566026: Implement skia sandbox callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix errors in checkin Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/SkFontHost_sandbox_win.h
diff --git a/skia/ext/SkFontHost_sandbox_win.h b/skia/ext/SkFontHost_sandbox_win.h
new file mode 100644
index 0000000000000000000000000000000000000000..a69f79607bd129fcdb01e84f3ec517a7afac9ff5
--- /dev/null
+++ b/skia/ext/SkFontHost_sandbox_win.h
@@ -0,0 +1,17 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
vandebo (ex-Chrome) 2011/11/18 21:35:18 Use Chrome filename naming conventions.
arthurhsu 2011/11/22 00:56:23 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
vandebo (ex-Chrome) 2011/11/18 21:35:18 Add generic include guards and pragma once: http:/
arthurhsu 2011/11/22 00:56:23 Done.
+#ifdef WIN32
vandebo (ex-Chrome) 2011/11/18 21:35:18 I don't think you need this guard.
arthurhsu 2011/11/22 00:56:23 Done.
+
+#include <windows.h>
+
+namespace skia {
+ class ISandboxSupport {
vandebo (ex-Chrome) 2011/11/18 21:35:18 If you want to note this as an interface, the Chro
vandebo (ex-Chrome) 2011/11/18 21:35:18 *** I don't think we need this to be a class. Coul
arthurhsu 2011/11/22 00:56:23 Use static global function pointer instead.
arthurhsu 2011/11/22 00:56:23 Done.
+ public:
+ virtual void EnsureFontLoad(LOGFONT logfont) = 0;
+ };
+ static ISandboxSupport* g_SkiaSandboxSupport;
vandebo (ex-Chrome) 2011/11/18 21:35:18 If we keep this as a class, should we make this pr
vandebo (ex-Chrome) 2011/11/18 21:35:18 skia/ext is considered Chrome code, so use Chrome
arthurhsu 2011/11/22 00:56:23 Use static global function pointer instead.
arthurhsu 2011/11/22 00:56:23 Done.
+}
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698