skia/ext/SkFontHost_sandbox_win.h - Issue 8566026: Implement skia sandbox callback

Side by Side Diff: skia/ext/SkFontHost_sandbox_win.h

Issue 8566026: Implement skia sandbox callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix errors in checkin Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
	vandebo (ex-Chrome) 2011/11/18 21:35:18 Use Chrome filename naming conventions. Use Chrome filename naming conventions. arthurhsu 2011/11/22 00:56:23 Done. Show quoted text On 2011/11/18 21:35:18, vandebo wrote: > Use Chrome filename naming conventions. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	vandebo (ex-Chrome) 2011/11/18 21:35:18 Add generic include guards and pragma once: http:/ Add generic include guards and pragma once: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#The__define_Guard arthurhsu 2011/11/22 00:56:23 Done. Show quoted text On 2011/11/18 21:35:18, vandebo wrote: > Add generic include guards and pragma once: > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#The__define_Guard Done.
	5 #ifdef WIN32
	vandebo (ex-Chrome) 2011/11/18 21:35:18 I don't think you need this guard. I don't think you need this guard. arthurhsu 2011/11/22 00:56:23 Done. Show quoted text On 2011/11/18 21:35:18, vandebo wrote: > I don't think you need this guard. Done.
	6

	7 #include <windows.h>

	8

	9 namespace skia {

	10 class ISandboxSupport {
	vandebo (ex-Chrome) 2011/11/18 21:35:18 If you want to note this as an interface, the Chro If you want to note this as an interface, the Chrome convention is an "Interface" suffix: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Interfaces vandebo (ex-Chrome) 2011/11/18 21:35:18 * I don't think we need this to be a class. Coul * I don't think we need this to be a class. Could we have just a function prototype and a global function pointer? arthurhsu 2011/11/22 00:56:23 Use static global function pointer instead. Show quoted text On 2011/11/18 21:35:18, vandebo wrote: > If you want to note this as an interface, the Chrome convention is an > "Interface" suffix: > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Interfaces Use static global function pointer instead. arthurhsu 2011/11/22 00:56:23 Done. Show quoted text On 2011/11/18 21:35:18, vandebo wrote: > *** I don't think we need this to be a class. Could we have just a function > prototype and a global function pointer? Done.
	11 public:

	12 virtual void EnsureFontLoad(LOGFONT logfont) = 0;

	13 };

	14 static ISandboxSupport* g_SkiaSandboxSupport;
	vandebo (ex-Chrome) 2011/11/18 21:35:18 If we keep this as a class, should we make this pr If we keep this as a class, should we make this private and add a static protected setter and static public getter? vandebo (ex-Chrome) 2011/11/18 21:35:18 skia/ext is considered Chrome code, so use Chrome skia/ext is considered Chrome code, so use Chrome naming conventions: g_skia_sandbox_support_; arthurhsu 2011/11/22 00:56:23 Use static global function pointer instead. Show quoted text On 2011/11/18 21:35:18, vandebo wrote: > If we keep this as a class, should we make this private and add a static > protected setter and static public getter? Use static global function pointer instead. arthurhsu 2011/11/22 00:56:23 Done. Show quoted text On 2011/11/18 21:35:18, vandebo wrote: > skia/ext is considered Chrome code, so use Chrome naming conventions: > g_skia_sandbox_support_; Done.
	15 }

	16

	17 #endif

OLD	NEW