Issue 8566025: print preview css: fix labels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566025: print preview css: fix labels (Closed)

Created:
9 years, 1 month ago by Evan Stade

Modified:
9 years, 1 month ago

Reviewers:
dpapad

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

print preview css: fix labels change from input label to label input span /label This is better because there are no blank spaces that are unclickable (the offsetting start padding and margin was attempting to get around this). Also we need it to be consistent with settings so we can make css rules that apply to both equally well. I removed aria-hidden attributes because those divs /should/ be using display:none when not visible. aria-hidden fixes it for screen readers but not for tab order. BUG=103688 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110037

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -40 lines)			Patch
M	chrome/browser/resources/options/options_page.css	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/print_preview/color_settings.html	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/print_preview/copies_settings.html	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/print_preview/copies_settings.js	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/print_preview/header_footer_settings.html	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/print_preview/layout_settings.html	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/print_preview/page_settings.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.css	View	5 chunks	+4 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8566025/1

9 years, 1 month ago (2011-11-15 02:39:13 UTC) #3

Change committed as 110037

Expand Messages | Collapse Messages