Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/resources/print_preview/copies_settings.js

Issue 8566025: print preview css: fix labels (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/copies_settings.js
diff --git a/chrome/browser/resources/print_preview/copies_settings.js b/chrome/browser/resources/print_preview/copies_settings.js
index 4a3737f4f7b43c36cf68869ee21057969de049b1..de0f9380e9f860d6a2e2ced9f8f5859bf4f1fc68 100644
--- a/chrome/browser/resources/print_preview/copies_settings.js
+++ b/chrome/browser/resources/print_preview/copies_settings.js
@@ -22,7 +22,7 @@ cr.define('print_preview', function() {
this.collateCheckbox_ = $('collate');
this.hint_ = $('copies-hint');
this.twoSidedCheckbox_ = $('two-sided');
- this.twoSidedOption_ = $('two-sided-div');
+ this.twoSidedOption_ = $('two-sided-option');
// Constant values matches printing::DuplexMode enum. Not using const
// keyword because it is not allowed by JS strict mode.
@@ -190,11 +190,6 @@ cr.define('print_preview', function() {
*/
showHideCollateOption_: function() {
this.collateOption_.hidden = this.numberOfCopies <= 1;
- // TODO(aayushkumar): Remove aria-hidden attribute once elements within
- // the hidden attribute are no longer read out by a screen-reader.
- // (Currently a bug in webkit).
- this.collateOption_.setAttribute('aria-hidden',
- this.collateOption_.hidden);
},
/*
@@ -210,8 +205,7 @@ cr.define('print_preview', function() {
// Ref bug: http://crbug.com/89204
this.twoSidedOption_.hidden =
(defaultDuplexValue == this.UNKNOWN_DUPLEX_MODE);
- this.twoSidedOption_.setAttribute('aria-hidden',
- this.twoSidedOption_.hidden);
+
if (!this.twoSidedOption_.hidden)
this.twoSidedCheckbox_.checked = !!defaultDuplexValue;
},

Powered by Google App Engine
This is Rietveld 408576698