Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 8566002: Use USE_VIRTUAL_KEYBOARD instead of TOUCH_UI when loading virtual keyboard component extension (Closed)

Created:
9 years, 1 month ago by hashimoto
Modified:
9 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use USE_VIRTUAL_KEYBOARD instead of TOUCH_UI when loading virtual keyboard component extension Use correct definition introduced in http://codereview.chromium.org/8051010 BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/component_loader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
9 years, 1 month ago (2011-11-14 12:33:57 UTC) #1
Yoyo Zhou
LGTM
9 years, 1 month ago (2011-11-14 15:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8566002/1
9 years, 1 month ago (2011-11-15 02:25:44 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 04:25:39 UTC) #4
Change committed as 110042

Powered by Google App Engine
This is Rietveld 408576698