Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8051010: Separate Virtual Keyboard related conditionals from TouchUI (Closed)

Created:
9 years, 2 months ago by hashimoto
Modified:
9 years, 2 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, davemoore+watch_chromium.org, stevenjb, arv (Not doing code reviews), Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Separate Virtual Keyboard related conditionals from TouchUI Add a gyp variable use_virtual_keyboard Add a cpp define USE_VIRTUAL_KEYBOARD Add a grit define use_virtual_keyboard BUG=chromium-os:10620 TEST=chrome and browser_tests compile successfully with GYP_DEFINES="touchui=1" and GYP_DEFINES="use_virtual_keyboard=1 use_only_pure_views=1". they run with a virtual keyboard with command-line option --views-desktop Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103926

Patch Set 1 #

Patch Set 2 : Rmoved mistakenly inserted blank line #

Patch Set 3 : Merged ToT #

Patch Set 4 : Rebased on ToT, modified resources/options/language_options.html #

Total comments: 2

Patch Set 5 : Rebased on ToT, fix along with review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -21 lines) Patch
M build/common.gypi View 1 2 3 4 5 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/touch/frame/touch_browser_frame_view.cc View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_notification_types.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
hashimoto
Related CL: "Move chrome/browser/ui/touch/keyboard* to chrome/browser/ui/virtual_keyboard/" http://codereview.chromium.org/8044018/
9 years, 2 months ago (2011-09-28 07:40:36 UTC) #1
hashimoto
ping? On 2011/09/28 07:40:36, hashimoto wrote: > Related CL: "Move chrome/browser/ui/touch/keyboard* to > chrome/browser/ui/virtual_keyboard/" http://codereview.chromium.org/8044018/
9 years, 2 months ago (2011-09-29 10:29:22 UTC) #2
bryeung
LGTM Sorry that took so long. I've been really bogged down in a combination of ...
9 years, 2 months ago (2011-10-03 18:03:08 UTC) #3
sadrul
http://codereview.chromium.org/8051010/diff/7001/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc File chrome/browser/ui/views/frame/opaque_browser_frame_view.cc (right): http://codereview.chromium.org/8051010/diff/7001/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc#newcode218 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc:218: #endif Quick nit: Please remove the keyboard initialization from ...
9 years, 2 months ago (2011-10-03 18:09:18 UTC) #4
hashimoto
Sorry for interrupting you in a busy week and thank your for reviewing! http://codereview.chromium.org/8051010/diff/7001/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc File ...
9 years, 2 months ago (2011-10-04 01:02:26 UTC) #5
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8051010/12001
9 years, 2 months ago (2011-10-04 13:34:53 UTC) #6
commit-bot: I haz the power
Presubmit check for 8051010-12001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 2 months ago (2011-10-04 13:43:39 UTC) #7
hashimoto
>mirandac@ Could you review my change on profile_impl.cc as an OWNER? Thanks,
9 years, 2 months ago (2011-10-04 14:08:26 UTC) #8
Miranda Callahan
On 2011/10/04 14:08:26, hashimoto wrote: > >mirandac@ > Could you review my change on profile_impl.cc ...
9 years, 2 months ago (2011-10-04 14:13:07 UTC) #9
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8051010/12001
9 years, 2 months ago (2011-10-04 14:26:35 UTC) #10
commit-bot: I haz the power
9 years, 2 months ago (2011-10-04 17:03:20 UTC) #11 
Change committed as 103926

Powered by Google App Engine
This is Rietveld 408576698