Issue 8565027: Revert 109461 -

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8565027: Revert 109461 - (Closed)

Created:
9 years, 1 month ago by Jeff Timanus

Modified:
9 years, 1 month ago

Reviewers:
Jeff Timanus

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 109461 - Re-introduction of release mode checks to determine the cause of CreateDIBSection failures. The crash is happening outside of the expected conditions in which CreateDIBSection would fail (large bitmap size, GDI and virtual memory pressure). To track the cause, this CL attempts to capture the last system error on bitmap allocation failure. See previous checks here: http://codereview.chromium.org/8341090 BUG=101934, 104063 TEST=NONE Review URL: http://codereview.chromium.org/8509030 TBR=twiz@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109978

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -58 lines)			Patch
	M	skia/ext/bitmap_platform_device_win.cc	View		2 chunks	+0 lines, -57 lines	0 comments	Download
	M	skia/ext/canvas_paint_win.h	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/twiz@chromium.org/8565027/1

9 years, 1 month ago (2011-11-14 21:54:59 UTC) #2

Change committed as 109978