Issue 8341090: Debug checks to make it easier to find reason for CanvasT<>::initialize crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341090: Debug checks to make it easier to find reason for CanvasT<>::initialize crash (Closed)

Created:
9 years, 1 month ago by groby-ooo-7-16

Modified:
9 years, 1 month ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Debug checks to make it easier to find reason for CanvasT<>::initialize crash BUG=101934 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108023

Patch Set 2 : Added missing includes #

Patch Set 3 : More compile fixes #

Total comments: 2

Patch Set 4 : Fix review nits #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -4 lines)			Patch
	M	skia/ext/bitmap_platform_device_win.cc	View	1 2 3	2 chunks	+34 lines, -0 lines	0 comments	Download
	M	skia/ext/canvas_paint_win.h	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

Added the CHECK statements we talked about this morning

9 years, 1 month ago (2011-10-28 00:39:03 UTC) #1

vandebo (ex-Chrome)

LGTM with nits. http://codereview.chromium.org/8341090/diff/4/skia/ext/bitmap_platform_device_win.cc File skia/ext/bitmap_platform_device_win.cc (right): http://codereview.chromium.org/8341090/diff/4/skia/ext/bitmap_platform_device_win.cc#newcode32 skia/ext/bitmap_platform_device_win.cc:32: // We use 64M pixels = ...

9 years, 1 month ago (2011-10-28 17:09:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8341090/4001

9 years, 1 month ago (2011-10-31 21:04:48 UTC) #5

Change committed as 108023