Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 8564040: Revert 110035 - Print Preview: Making margin selection sticky (part 2/2) (Closed)

Created:
9 years, 1 month ago by dpapad
Modified:
9 years, 1 month ago
Reviewers:
dpapad
CC:
chromium-reviews, brettw-cc_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 110035 - Print Preview: Making margin selection sticky (part 2/2) This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session. Here is a summary of all changes. - Within same preview session: So far selecting "Custom" was picking up from whatever the previous selected option was. Now, "Custom" remembers the specified margins. To test this select "Custom", do some dragging, then change to another option and back to "Custom". - Across preview sessions: Select "Custom", do some dragging, then print. Open print preview again, the last used custom margins are remembered. - There was a bunch of messages sent from JS to get various info/settings (initiator tab title, measurement system and number format, last used margin settings, default printer). I created a single message "getInitialSettings" to get all at once (they are needed before the 1st preview is is requested). BUG=102446 TEST=See bug description. Review URL: http://codereview.chromium.org/8351048 TBR=dpapad@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -581 lines) Patch
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/printing/print_system_task_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_system_task_proxy.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/resources/print_preview/margin_settings.js View 16 chunks +40 lines, -88 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 6 chunks +19 lines, -30 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 5 chunks +13 lines, -25 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 9 chunks +54 lines, -84 lines 0 comments Download
D chrome/browser/ui/webui/print_preview_handler_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.h View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/print_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 2 chunks +2 lines, -2 lines 0 comments Download
MM printing/page_size_margins.h View 2 chunks +1 line, -7 lines 0 comments Download
D printing/page_size_margins.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M printing/printing.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context.cc View 2 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dpapad
9 years, 1 month ago (2011-11-15 04:07:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698