Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: chrome/browser/printing/print_system_task_proxy.cc

Issue 8564040: Revert 110035 - Print Preview: Making margin selection sticky (part 2/2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_system_task_proxy.cc
===================================================================
--- chrome/browser/printing/print_system_task_proxy.cc (revision 110039)
+++ chrome/browser/printing/print_system_task_proxy.cc (working copy)
@@ -316,22 +316,25 @@
void PrintSystemTaskProxy::GetDefaultPrinter() {
VLOG(1) << "Get default printer start";
- std::string* default_printer = NULL;
+ StringValue* default_printer = NULL;
if (PrintPreviewHandler::last_used_printer_name_ == NULL) {
- default_printer = new std::string(print_backend_->GetDefaultPrinterName());
+ default_printer = new StringValue(
+ print_backend_->GetDefaultPrinterName());
} else {
- default_printer = new std::string(
+ default_printer = new StringValue(
*PrintPreviewHandler::last_used_printer_name_);
}
+ std::string default_printer_string;
+ default_printer->GetAsString(&default_printer_string);
VLOG(1) << "Get default printer finished, found: "
- << default_printer;
+ << default_printer_string;
- std::string* cloud_print_data = NULL;
+ StringValue* cloud_print_data = NULL;
if (PrintPreviewHandler::last_used_printer_cloud_print_data_ != NULL) {
- cloud_print_data = new std::string(
+ cloud_print_data = new StringValue(
*PrintPreviewHandler::last_used_printer_cloud_print_data_);
} else {
- cloud_print_data = new std::string;
+ cloud_print_data = new StringValue("");
}
BrowserThread::PostTask(
@@ -341,9 +344,9 @@
}
void PrintSystemTaskProxy::SendDefaultPrinter(
- const std::string* default_printer, const std::string* cloud_print_data) {
+ const StringValue* default_printer, const StringValue* cloud_print_data) {
if (handler_)
- handler_->SendInitialSettings(*default_printer, *cloud_print_data);
+ handler_->SendDefaultPrinter(*default_printer, *cloud_print_data);
delete default_printer;
}
« no previous file with comments | « chrome/browser/printing/print_system_task_proxy.h ('k') | chrome/browser/resources/print_preview/margin_settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698