Issue 8564021: touchui: Fix a crash on consecutive volume/brightness bubble display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8564021: touchui: Fix a crash on consecutive volume/brightness bubble display. (Closed)

Created:
9 years, 1 month ago by sadrul

Modified:
9 years, 1 month ago

Reviewers:
msw, sky

CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina, dhollowa, cwolfe

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

touchui: Fix a crash on consecutive volume/brightness bubble display. The ownership of NWView/NWViews should not be affected by whether there is a parent widget or not. So use the default ownership. BUG=104152 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109969

Patch Set 1 #

Patch Set 2 : . #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
M	views/bubble/bubble_delegate.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	views/bubble/bubble_delegate_unittest.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	views/bubble/bubble_frame_view_unittest.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages