views/bubble/bubble_frame_view_unittest.cc - Issue 8564021: touchui: Fix a crash on consecutive volume/brightness bubble display.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: views/bubble/bubble_frame_view_unittest.cc

Issue 8564021: touchui: Fix a crash on consecutive volume/brightness bubble display. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « views/bubble/bubble_delegate_unittest.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/base/hit_test.h"	5 #include "ui/base/hit_test.h"

6 #include "views/bubble/bubble_border.h"	6 #include "views/bubble/bubble_border.h"

7 #include "views/bubble/border_contents_view.h"	7 #include "views/bubble/border_contents_view.h"

8 #include "views/bubble/bubble_delegate.h"	8 #include "views/bubble/bubble_delegate.h"

9 #include "views/bubble/bubble_frame_view.h"	9 #include "views/bubble/bubble_frame_view.h"

10 #include "views/test/views_test_base.h"	10 #include "views/test/views_test_base.h"

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 private:	47 private:

48 DISALLOW_COPY_AND_ASSIGN(SizedBubbleDelegateView);	48 DISALLOW_COPY_AND_ASSIGN(SizedBubbleDelegateView);

49 };	49 };

50	50

51 gfx::Size SizedBubbleDelegateView::GetPreferredSize() { return kRect.size(); }	51 gfx::Size SizedBubbleDelegateView::GetPreferredSize() { return kRect.size(); }

52	52

53 } // namespace	53 } // namespace

54	54

55 TEST_F(BubbleFrameViewBasicTest, NonClientHitTest) {	55 TEST_F(BubbleFrameViewBasicTest, NonClientHitTest) {

56 BubbleDelegateView* delegate = new SizedBubbleDelegateView();	56 BubbleDelegateView* delegate = new SizedBubbleDelegateView();

57 scoped_ptr<Widget> widget(BubbleDelegateView::CreateBubble(delegate));	57 Widget* widget(BubbleDelegateView::CreateBubble(delegate));

58 delegate->Show();	58 delegate->Show();

59 gfx::Point kPtInBound(100, 100);	59 gfx::Point kPtInBound(100, 100);

60 gfx::Point kPtOutsideBound(1000, 1000);	60 gfx::Point kPtOutsideBound(1000, 1000);

61 BubbleFrameView* bubble_frame_view = delegate->GetBubbleFrameView();	61 BubbleFrameView* bubble_frame_view = delegate->GetBubbleFrameView();

62 EXPECT_EQ(HTCLIENT, bubble_frame_view->NonClientHitTest(kPtInBound));	62 EXPECT_EQ(HTCLIENT, bubble_frame_view->NonClientHitTest(kPtInBound));

63 EXPECT_EQ(HTNOWHERE, bubble_frame_view->NonClientHitTest(kPtOutsideBound));	63 EXPECT_EQ(HTNOWHERE, bubble_frame_view->NonClientHitTest(kPtOutsideBound));

64 widget->CloseNow();	64 widget->CloseNow();

65 widget.reset();

66 RunPendingMessages();	65 RunPendingMessages();

67 }	66 }

68	67

69 } // namespace views	68 } // namespace views

OLD	NEW