Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 8564015: Fix DoubleClickInterval and DragThreshold on aura. (Closed)

Created:
9 years, 1 month ago by jennyz
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, penghuang+watch_chromium.org, Paweł Hajdan Jr., James Su, dhollowa
Visibility:
Public.

Description

Fix DoubleClickInterval and DragThreshold on aura. BUG=101774 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110140

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a comment regarding NonClientMouseClick() and Sleep in unit test. #

Patch Set 3 : ifdef the sleep call work around in unit test. #

Patch Set 4 : NonClientMouseClick() does not work on os_win. #

Patch Set 5 : Fix a typo in comment. #

Total comments: 2

Patch Set 6 : Disable part of OverflowInRTLTest on os_win. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M views/controls/textfield/native_textfield_views_unittest.cc View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M views/metrics_aura.cc View 1 chunk +10 lines, -1 line 0 comments Download
M views/view_aura.cc View 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jennyz
This cl is the same as the following cl: http://codereview.chromium.org/8524008/ But 8524008 was checked in ...
9 years, 1 month ago (2011-11-14 17:54:06 UTC) #1
sky
http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native_textfield_views_unittest.cc#newcode1541 views/controls/textfield/native_textfield_views_unittest.cc:1541: base::PlatformThread::Sleep(1000); Having tests sleep doesn't scale. Isn't there a ...
9 years, 1 month ago (2011-11-14 18:12:30 UTC) #2
jennyz
http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native_textfield_views_unittest.cc#newcode1541 views/controls/textfield/native_textfield_views_unittest.cc:1541: base::PlatformThread::Sleep(1000); On 2011/11/14 18:12:31, sky wrote: > Having tests ...
9 years, 1 month ago (2011-11-14 18:41:35 UTC) #3
sky
I would rather ifdef than sleep. Maybe you could click some where else first so ...
9 years, 1 month ago (2011-11-14 21:09:21 UTC) #4
jennyz
On 2011/11/14 21:09:21, sky wrote: > I would rather ifdef than sleep. Maybe you could ...
9 years, 1 month ago (2011-11-14 21:47:30 UTC) #5
jennyz
Added ifdef to surround the win_aura work around for avoiding double click in test case.
9 years, 1 month ago (2011-11-14 21:48:32 UTC) #6
sky
http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/native_textfield_views_unittest.cc#newcode1540 views/controls/textfield/native_textfield_views_unittest.cc:1540: #if defined(OS_WIN) Sorry I wasn't clear. You should disable ...
9 years, 1 month ago (2011-11-15 00:30:26 UTC) #7
jennyz
http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/native_textfield_views_unittest.cc#newcode1540 views/controls/textfield/native_textfield_views_unittest.cc:1540: #if defined(OS_WIN) On 2011/11/15 00:30:26, sky wrote: > Sorry ...
9 years, 1 month ago (2011-11-15 01:00:27 UTC) #8
sky
LGTM
9 years, 1 month ago (2011-11-15 01:49:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/8564015/7007
9 years, 1 month ago (2011-11-15 17:43:19 UTC) #10
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 19:18:15 UTC) #11
Change committed as 110140

Powered by Google App Engine
This is Rietveld 408576698