Fix DoubleClickInterval and DragThreshold on aura.

Fix DoubleClickInterval and DragThreshold on aura.


BUG=101774
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110140

[jennyz, 2011-11-14 17:54:06]

This cl is the same as the following cl:
http://codereview.chromium.org/8524008/

But 8524008 was checked in and reverted due to breaking a RTL unit test on
win_aura. I fixed the unit test, xji and msw has reviewed and lgtm and code.
Since the 8524008 is marked as closed, so I patched it to a new branch and
create a cl for it. Please take a look!

[sky, 2011-11-14 18:12:30]

http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
File views/controls/textfield/native_textfield_views_unittest.cc (right):

http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
views/controls/textfield/native_textfield_views_unittest.cc:1541:
base::PlatformThread::Sleep(1000);
Having tests sleep doesn't scale. Isn't there a better way to force the click to
be treated as a double click?

[jennyz, 2011-11-14 18:41:35]

http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
File views/controls/textfield/native_textfield_views_unittest.cc (right):

http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
views/controls/textfield/native_textfield_views_unittest.cc:1541:
base::PlatformThread::Sleep(1000);
On 2011/11/14 18:12:31, sky wrote:
> Having tests sleep doesn't scale. Isn't there a better way to force the click
to
> be treated as a double click?
Please see the comments in http://codereview.chromium.org/8524008/
There seems some issue with NonClientMouseClick() with win_aura build, which
does not work here. I discussed with xji and she thought it is ok to make a work
around here. I filed a bug for it.

[sky, 2011-11-14 21:09:21]

I would rather ifdef than sleep. Maybe you could click some where else
first so the system doesn't interpret the click as a double click.

  -Scott

On Mon, Nov 14, 2011 at 10:41 AM,  <jennyz@chromium.org> wrote:
>
>
http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
> File views/controls/textfield/native_textfield_views_unittest.cc
> (right):
>
>
http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
> views/controls/textfield/native_textfield_views_unittest.cc:1541:
> base::PlatformThread::Sleep(1000);
> On 2011/11/14 18:12:31, sky wrote:
>>
>> Having tests sleep doesn't scale. Isn't there a better way to force
>
> the click to
>>
>> be treated as a double click?
>
> Please see the comments in http://codereview.chromium.org/8524008/
> There seems some issue with NonClientMouseClick() with win_aura build,
> which does not work here. I discussed with xji and she thought it is ok
> to make a work around here. I filed a bug for it.
>
> http://codereview.chromium.org/8564015/
>

[jennyz, 2011-11-14 21:47:30]

On 2011/11/14 21:09:21, sky wrote:
> I would rather ifdef than sleep. Maybe you could click some where else
> first so the system doesn't interpret the click as a double click.
> 
>   -Scott
> 
> On Mon, Nov 14, 2011 at 10:41 AM,  <mailto:jennyz@chromium.org> wrote:
> >
> >
>
http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
> > File views/controls/textfield/native_textfield_views_unittest.cc
> > (right):
> >
> >
>
http://codereview.chromium.org/8564015/diff/1/views/controls/textfield/native...
> > views/controls/textfield/native_textfield_views_unittest.cc:1541:
> > base::PlatformThread::Sleep(1000);
> > On 2011/11/14 18:12:31, sky wrote:
> >>
> >> Having tests sleep doesn't scale. Isn't there a better way to force
> >
> > the click to
> >>
> >> be treated as a double click?
> >
> > Please see the comments in http://codereview.chromium.org/8524008/
> > There seems some issue with NonClientMouseClick() with win_aura build,
> > which does not work here. I discussed with xji and she thought it is ok
> > to make a work around here. I filed a bug for it.
> >
> > http://codereview.chromium.org/8564015/
> >
I added the ifdef for the sleep call.

[jennyz, 2011-11-14 21:48:32]

Added ifdef to surround the win_aura work around for avoiding double click in
test case.

[sky, 2011-11-15 00:30:26]

http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views_unittest.cc (right):

http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views_unittest.cc:1540: #if
defined(OS_WIN)
Sorry I wasn't clear. You should disable this test on OS_WIN until we don't need
the sleep. That's what I meant by the ifdef.

[jennyz, 2011-11-15 01:00:27]

http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views_unittest.cc (right):

http://codereview.chromium.org/8564015/diff/6003/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views_unittest.cc:1540: #if
defined(OS_WIN)
On 2011/11/15 00:30:26, sky wrote:
> Sorry I wasn't clear. You should disable this test on OS_WIN until we don't
need
> the sleep. That's what I meant by the ifdef.

Done.

[sky, 2011-11-15 01:49:27]

LGTM

[commit-bot: I haz the power, 2011-11-15 17:43:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/8564015/7007

[commit-bot: I haz the power, 2011-11-15 19:18:15]

Change committed as 110140