Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: views/controls/textfield/native_textfield_views_unittest.cc

Issue 8564015: Fix DoubleClickInterval and DragThreshold on aura. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable part of OverflowInRTLTest on os_win. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/metrics_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/textfield/native_textfield_views_unittest.cc
diff --git a/views/controls/textfield/native_textfield_views_unittest.cc b/views/controls/textfield/native_textfield_views_unittest.cc
index f3a046aac875911f89685bce48a0822cec681c19..03b6cb7ad3d1f7320bfb0317f4a59493786efea4 100644
--- a/views/controls/textfield/native_textfield_views_unittest.cc
+++ b/views/controls/textfield/native_textfield_views_unittest.cc
@@ -1537,6 +1537,14 @@ TEST_F(NativeTextfieldViewsTest, OverflowInRTLTest) {
display = GetDisplayRect();
OverflowCursorBoundTestVerifier(display, bound);
+
+#if !defined(OS_WIN)
+ // TODO(jennyz): NonClientMouseClick() does not work for os_win builds;
+ // see crbug.com/104150. The mouse click in the next test will be confused
+ // as a double click, which breaks the test. Disable the test until the
+ // issue is fixed.
+ NonClientMouseClick();
+
MouseClick(bound, 1);
#if defined(OS_WIN)
// In Windows, the text is always in LTR directionality even in RTL UI.
@@ -1546,6 +1554,7 @@ TEST_F(NativeTextfieldViewsTest, OverflowInRTLTest) {
#else
EXPECT_EQ(500U, textfield_->GetCursorPosition());
#endif
+#endif // !defined(OS_WIN)
// Reset locale.
base::i18n::SetICUDefaultLocale(locale);
« no previous file with comments | « no previous file | views/metrics_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698