Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 8564003: Mark more worker tests flaky, and across more platforms. (Closed)

Created:
9 years, 1 month ago by Jói
Modified:
9 years, 1 month ago
Reviewers:
Finnur
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Mark more worker tests flaky, and across more platforms. I've been watching the tree for a few days and it seems that tests that start to flake due to http://crbug.com/101996 on one or two platforms will also show flakiness (possibly less, but still) on the other platforms. Also cleaned up a couple of cases where tests were marked flaky for 3 out of 4 platforms, and a couple of other changes based on going through the flakiness dashboard for WorkerTest and WorkerFileSystemTest. TBR=jam@chromium.org BUG=101996 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109867

Patch Set 1 #

Total comments: 4

Patch Set 2 : Mark more tests that have been recently flaky on waterfall. #

Patch Set 3 : Respond to review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -82 lines) Patch
M content/worker/test/worker_uitest.cc View 1 2 10 chunks +25 lines, -82 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jói
9 years, 1 month ago (2011-11-14 11:20:05 UTC) #1
Finnur
LGTM, one nit, one question. http://codereview.chromium.org/8564003/diff/1/content/worker/test/worker_uitest.cc File content/worker/test/worker_uitest.cc (right): http://codereview.chromium.org/8564003/diff/1/content/worker/test/worker_uitest.cc#newcode280 content/worker/test/worker_uitest.cc:280: // Flaky (all platforms), ...
9 years, 1 month ago (2011-11-14 11:30:10 UTC) #2
Jói
9 years, 1 month ago (2011-11-14 11:33:00 UTC) #3
Uploaded new version.  Will commit once trybots have compiled the file.

http://codereview.chromium.org/8564003/diff/1/content/worker/test/worker_uite...
File content/worker/test/worker_uitest.cc (right):

http://codereview.chromium.org/8564003/diff/1/content/worker/test/worker_uite...
content/worker/test/worker_uitest.cc:280: // Flaky (all platforms),
http://crbug.com/84203.
On 2011/11/14 11:30:10, Finnur wrote:
> nit: The Flaky comment is now redundant, just say:
> // http://crbug.com/84203.

Done.

http://codereview.chromium.org/8564003/diff/1/content/worker/test/worker_uite...
content/worker/test/worker_uitest.cc:607: // Times out consistently on Windows.
On 2011/11/14 11:30:10, Finnur wrote:
> ... occasionally on others?

The lines above have it covered I think - hangs on Linux, causes ui_tests to
hang on Mac.  But I'll modify the comment to state that it times out
consistently on all platforms, since that's what the flakiness dashboard shows.

Powered by Google App Engine
This is Rietveld 408576698