Mark more worker tests flaky, and across more platforms.

content/worker/test/worker_uitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/string_util.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/platform_thread.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/test/automation/automation_proxy.h"
@@ skipping 233 matching lines @@
 
   scoped_refptr<TabProxy> tab(GetActiveTab());
   ASSERT_TRUE(tab.get());
 
   GURL url = test_server.GetURL("files/shared_worker_auth.html");
   EXPECT_TRUE(NavigateAndWaitForAuth(tab, url));
   // TODO(atwilson): Add support to automation framework to test for auth
   // dialogs displayed by non-navigating tabs.
 }
 
-#if defined(OS_WIN)
 // http://crbug.com/101996
-#define StressJSExecution FLAKY_StressJSExecution
-#endif
-TEST_F(WorkerTest, StressJSExecution) {
+TEST_F(WorkerTest, FLAKY_StressJSExecution) {
   RunWorkerFastLayoutTest("stress-js-execution.html");
 }
 
-#if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996
-#define UseMachineStack FLAKY_UseMachineStack
-#endif
-TEST_F(WorkerTest, UseMachineStack) {
+TEST_F(WorkerTest, FLAKY_UseMachineStack) {
   RunWorkerFastLayoutTest("use-machine-stack.html");
 }
 
-#if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996
-#define WorkerCall FLAKY_WorkerCall
-#endif
-TEST_F(WorkerTest, WorkerCall) {
+TEST_F(WorkerTest, FLAKY_WorkerCall) {
   RunWorkerFastLayoutTest("worker-call.html");
 }
 
 // Crashy, http://crbug.com/35965.
 // Flaky, http://crbug.com/36555.
 TEST_F(WorkerTest, DISABLED_WorkerClonePort) {
   RunWorkerFastLayoutTest("worker-cloneport.html");
 }
 
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996
-#define WorkerCloseFast FLAKY_WorkerCloseFast
-#endif
-TEST_F(WorkerTest, WorkerCloseFast) {
+TEST_F(WorkerTest, FLAKY_WorkerCloseFast) {
   RunWorkerFastLayoutTest("worker-close.html");
 }
 
-// Flaky (on XP), http://crbug.com/84203.
+// Flaky (all platforms), http://crbug.com/84203.

[Finnur, 2011/11/14 11:30:10]

nit: The Flaky comment is now redundant, just say:
// http://crbug.com/84203.

[Jói, 2011/11/14 11:33:00]

Done.

 TEST_F(WorkerTest, FLAKY_WorkerConstructor) {
   RunWorkerFastLayoutTest("worker-constructor.html");
 }
 
-#if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996
-#define WorkerContextGc FLAKY_WorkerContextGc
-#endif
-TEST_F(WorkerTest, WorkerContextGc) {
+TEST_F(WorkerTest, FLAKY_WorkerContextGc) {
   RunWorkerFastLayoutTest("worker-context-gc.html");
 }
 
-#if defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define WorkerContextMultiPort FLAKY_WorkerContextMultiPort
-#endif
-TEST_F(WorkerTest, WorkerContextMultiPort) {
+TEST_F(WorkerTest, FLAKY_WorkerContextMultiPort) {
   RunWorkerFastLayoutTest("worker-context-multi-port.html");
 }
 
-#if defined(OS_MAC) || defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996
-#define WorkerEventListener FLAKY_WorkerEventListener
-#endif
-TEST_F(WorkerTest, WorkerEventListener) {
+TEST_F(WorkerTest, FLAKY_WorkerEventListener) {
   RunWorkerFastLayoutTest("worker-event-listener.html");
 }
 
-#if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define WorkerGC FLAKY_WorkerGC
-#endif
-TEST_F(WorkerTest, WorkerGC) {
+TEST_F(WorkerTest, FLAKY_WorkerGC) {
   RunWorkerFastLayoutTest("worker-gc.html");
 }
 
-#if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define WorkerInit FLAKY_WorkerInit
-#endif
-TEST_F(WorkerTest, WorkerInit) {
+TEST_F(WorkerTest, FLAKY_WorkerInit) {
   RunWorkerFastLayoutTest("worker-init.html");
 }
 
 // worker-lifecycle.html relies on layoutTestController.workerThreadCount
 // which is not currently implemented. http://crbug.com/45168
 TEST_F(WorkerTest, DISABLED_WorkerLifecycle) {
   RunWorkerFastLayoutTest("worker-lifecycle.html");
 }
 
 #if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
 #define WorkerLocation FLAKY_WorkerLocation
 #endif
 TEST_F(WorkerTest, WorkerLocation) {
   RunWorkerFastLayoutTest("worker-location.html");
 }
 
 // Flaky, http://crbug.com/71518.
 TEST_F(WorkerTest, FLAKY_WorkerMapGc) {
   RunWorkerFastLayoutTest("wrapper-map-gc.html");
 }
 
-#if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define WorkerMessagePort FLAKY_WorkerMessagePort
-#endif
-TEST_F(WorkerTest, WorkerMessagePort) {
+TEST_F(WorkerTest, FLAKY_WorkerMessagePort) {
   RunWorkerFastLayoutTest("worker-messageport.html");
 }
 
 #if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
 #define WorkerMessagePortGC FLAKY_WorkerMessagePortGC
 #endif
 TEST_F(WorkerTest, WorkerMessagePortGC) {
   RunWorkerFastLayoutTest("worker-messageport-gc.html");
 }
 
-TEST_F(WorkerTest, WorkerMultiPort) {
+// http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
+TEST_F(WorkerTest, FLAKY_WorkerMultiPort) {
   RunWorkerFastLayoutTest("worker-multi-port.html");
 }
 
 // Flaky, http://crbug.com/76426.
 TEST_F(WorkerTest, FLAKY_WorkerNavigator) {
   RunWorkerFastLayoutTest("worker-navigator.html");
 }
 
 #if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
 #define WorkerReplaceGlobalConstructor FLAKY_WorkerReplaceGlobalConstructor
 #endif
 TEST_F(WorkerTest, WorkerReplaceGlobalConstructor) {
   RunWorkerFastLayoutTest("worker-replace-global-constructor.html");
 }
 
-#if defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define WorkerReplaceSelf FLAKY_WorkerReplaceSelf
-#endif
-TEST_F(WorkerTest, WorkerReplaceSelf) {
+TEST_F(WorkerTest, FLAKY_WorkerReplaceSelf) {
   RunWorkerFastLayoutTest("worker-replace-self.html");
 }
 
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(OS_LINUX)
 // Mac: http://crbug.com/44457
-// Windows: http://crbug.com/101996
-#define WorkerScriptError FLAKY_WorkerScriptError
-#endif
-TEST_F(WorkerTest, WorkerScriptError) {
+// Others: http://crbug.com/101996
+TEST_F(WorkerTest, FLAKY_WorkerScriptError) {
   RunWorkerFastLayoutTest("worker-script-error.html");
 }
 
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define WorkerTerminate FLAKY_WorkerTerminate
-#endif
-TEST_F(WorkerTest, WorkerTerminate) {
+TEST_F(WorkerTest, FLAKY_WorkerTerminate) {
   RunWorkerFastLayoutTest("worker-terminate.html");
 }
 
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define WorkerTimeout FLAKY_WorkerTimeout
-#endif
-TEST_F(WorkerTest, WorkerTimeout) {
+TEST_F(WorkerTest, FLAKY_WorkerTimeout) {
   RunWorkerFastLayoutTest("worker-timeout.html");
 }
 
 //
 // SharedWorkerFastLayoutTests
 //
 // http://crbug.com/27636 - incorrect URL_MISMATCH exceptions sometimes get
 // generated on the windows try bots. FLAKY on Win.
 // http://crbug.com/28445 - flakiness on mac
 TEST_F(WorkerTest, FLAKY_SharedWorkerFastConstructor) {
@@ skipping 207 matching lines @@
   GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir),
                                        FilePath(kManyWorkersFile));
   url = GURL(url.spec() + StringPrintf("?count=%d", max_workers_per_tab + 1));
 
   NavigateToURL(url);
   ASSERT_TRUE(WaitForProcessCountToBe(1, max_workers_per_tab));
 }
 
 // Doesn't crash, but on all platforms, it sometimes fails.
 // Flaky on all platforms: http://crbug.com/28445
-#if defined(OS_LINUX)
 // Hangs on Linux: http://crbug.com/30332
-#define FLAKY_LimitTotal DISABLED_LimitTotal
-#elif defined(OS_MACOSX)
 // Possibly causing ui_tests to hang on Mac: http://crbug.com/88958
-#define FLAKY_LimitTotal DISABLED_LimitTotal
-#endif
-TEST_F(WorkerTest, FLAKY_LimitTotal) {
+// Times out consistently on Windows.

[Finnur, 2011/11/14 11:30:10]

... occasionally on others?

[Jói, 2011/11/14 11:33:00]

The lines above have it covered I think - hangs on Linux, causes ui_tests to
hang on Mac.  But I'll modify the comment to state that it times out
consistently on all platforms, since that's what the flakiness dashboard shows.

+TEST_F(WorkerTest, DISABLED_LimitTotal) {
   int max_workers_per_tab = WorkerService::kMaxWorkersPerTabWhenSeparate;
   int total_workers = WorkerService::kMaxWorkersWhenSeparate;
 
   int tab_count = (total_workers / max_workers_per_tab) + 1;
   GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir),
                                        FilePath(kManyWorkersFile));
   url = GURL(url.spec() + StringPrintf("?count=%d", max_workers_per_tab));
 
   scoped_refptr<TabProxy> tab(GetActiveTab());
   ASSERT_TRUE(tab.get());
@@ skipping 214 matching lines @@
 }
 
 #if defined(OS_LINUX) || defined(OS_MACOSX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
 #define SyncOperations FLAKY_SyncOperations
 #endif
 TEST_F(WorkerFileSystemTest, SyncOperations) {
   RunWorkerFileSystemLayoutTest("sync-operations.html");
 }
 
-#if defined(OS_LINUX)
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
-#define FileEntryToURISync FLAKY_FileEntryToURISync
-#endif
-TEST_F(WorkerFileSystemTest, FileEntryToURISync) {
+TEST_F(WorkerFileSystemTest, FLAKY_FileEntryToURISync) {
   RunWorkerFileSystemLayoutTest("file-entry-to-uri-sync.html");
 }
 
 // http://crbug.com/77442
 TEST_F(WorkerFileSystemTest, FLAKY_ResolveURLHttpTests) {
   static const char* kLayoutTests[] = {
     "resolve-url.html",
     "resolve-url-sync.html"
   };
   RunWorkerFileSystemLayoutHttpTests(kLayoutTests, arraysize(kLayoutTests));
 }
 
 #if defined(OS_LINUX)
 // Fails on Linux due to an assert in WebKit's RNG.
 // See http://webkit.org/b/55728.
 #define FileFromFileEntry DISABLED_FileFromFileEntry
 #endif
 TEST_F(WorkerFileSystemTest, FileFromFileEntry) {
   RunWorkerFileSystemLayoutTest("file-from-file-entry.html");
 }
 
 #if defined(OS_LINUX)
 // Fails on Linux due to an assert in WebKit's RNG.
 // See http://webkit.org/b/55728.
 #define FileFromFileEntrySync DISABLED_FileFromFileEntrySync
-#elif defined(OS_MACOSX)
+#else
 // http://crbug.com/101996 (started flaking with WebKit roll 98537:98582).
 #define FileFromFileEntrySync FLAKY_FileFromFileEntrySync
 #endif
 TEST_F(WorkerFileSystemTest, FileFromFileEntrySync) {
   RunWorkerFileSystemLayoutTest("file-from-file-entry-sync.html");
 }
 
 #if defined(OS_LINUX)
 // Fails on Linux due to an assert in WebKit's RNG.
 // See http://webkit.org/b/55728.
@@ skipping 13 matching lines @@
 }
 
 #if defined(OS_LINUX)
 // Fails on Linux due to an assert in WebKit's RNG.
 // See http://webkit.org/b/55728.
 #define FileWriterSyncWriteOverlapped DISABLED_FileWriterSyncWriteOverlapped
 #endif
 TEST_F(WorkerFileSystemTest, FileWriterSyncWriteOverlapped) {
   RunWorkerFileSystemLayoutTest("file-writer-sync-write-overlapped.html");
 }