Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8561006: GTK: Speculative revert of r109465 to fix right clicking. (Closed)

Created:
9 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, kerz_chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Speculative revert of r109465 to fix right clicking. BUG=104190, 103535 TEST=Fixes right clicking on Fedora per bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110835

Patch Set 1 #

Patch Set 2 : Fix stupid typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Elliot Glaysher
estade: review of this betablocker fix kerz: fyi
9 years, 1 month ago (2011-11-18 01:04:54 UTC) #1
Evan Stade
lgtm. GDK_CURRENT_TIME is 0, so it doesn't do the job --- there's a reason I ...
9 years, 1 month ago (2011-11-18 04:06:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8561006/2001
9 years, 1 month ago (2011-11-18 18:22:04 UTC) #3
commit-bot: I haz the power
Try job failure for 8561006-2001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-18 19:47:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8561006/2001
9 years, 1 month ago (2011-11-18 20:09:49 UTC) #5
commit-bot: I haz the power
Try job failure for 8561006-2001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-18 21:08:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8561006/2001
9 years, 1 month ago (2011-11-18 21:12:13 UTC) #7
commit-bot: I haz the power
Try job failure for 8561006-2001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-18 22:09:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8561006/2001
9 years, 1 month ago (2011-11-18 23:25:18 UTC) #9
commit-bot: I haz the power
Try job failure for 8561006-2001 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
9 years, 1 month ago (2011-11-19 00:57:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8561006/2001
9 years, 1 month ago (2011-11-19 01:26:38 UTC) #11
commit-bot: I haz the power
Try job failure for 8561006-2001 (retry) (retry) on linux_rel for step "ui_tests". It's a second ...
9 years, 1 month ago (2011-11-19 02:45:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8561006/2001
9 years, 1 month ago (2011-11-19 05:53:36 UTC) #13
commit-bot: I haz the power
9 years, 1 month ago (2011-11-19 07:35:56 UTC) #14 
Change committed as 110835

Powered by Google App Engine
This is Rietveld 408576698