Issue 8558013: Add API tests for all input.ime functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8558013: Add API tests for all input.ime functions. (Closed)

Created:
9 years, 1 month ago by Zachary Kuznia

Modified:
9 years, 1 month ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add API tests for all input.ime functions. R=mpcomplete@chromium.org BUG=chromium-os:23194 TEST=Run browser_tests --gtest_filter="ExtensionApiTest.InputImeApiBasic" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110884

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review fixes #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -32 lines)			Patch
M	chrome/browser/extensions/extension_input_ime_api.h	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_input_ime_api.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View		2 chunks	+23 lines, -15 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/input_ime/background.html	View	1	3 chunks	+83 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

The TEST= in the CL description is testing instructions for QA, so no need to ...

9 years, 1 month ago (2011-11-18 20:16:37 UTC) #2

Zachary Kuznia

9 years, 1 month ago (2011-11-21 05:30:21 UTC) #4

http://codereview.chromium.org/8558013/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/input_ime/background.html (right):

http://codereview.chromium.org/8558013/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/input_ime/background.html:13: }, function
() {
On 2011/11/18 20:16:37, Matt Perry wrote:
> note, you can also wrap the callbacks in a chrome.test.callbackPass() call,
> which will automatically call chrome.test.succeed when all pending callbacks
> run.

Done.

Expand Messages | Collapse Messages