chrome/browser/extensions/extension_input_ime_api.cc - Issue 8558013: Add API tests for all input.ime functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_input_ime_api.cc

Issue 8558013: Add API tests for all input.ime functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review fixes Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_input_ime_api.cc

diff --git a/chrome/browser/extensions/extension_input_ime_api.cc b/chrome/browser/extensions/extension_input_ime_api.cc

index 7e77af9d5da4ab0eeca5c393f9e221da37f8004d..febef50e7bae4a5d59d61619f99349baf302a764 100644

--- a/chrome/browser/extensions/extension_input_ime_api.cc

+++ b/chrome/browser/extensions/extension_input_ime_api.cc

@@ -779,9 +779,9 @@ bool SetCursorPositionFunction::RunImpl() {

int candidate_id;

EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kContextIdKey,

- &context_id));

+ &context_id));

EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kCandidateIdKey,

- &candidate_id));

+ &candidate_id));

if (engine->SetCursorPosition(context_id, candidate_id, &error_)) {

result_.reset(Value::CreateBooleanValue(true));